Bug 114566 - REGRESSION (r147261): Flex box regression: min-height defaults to 0 instead of -webkit-min-content
Summary: REGRESSION (r147261): Flex box regression: min-height defaults to 0 instead o...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.8
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar, NeedsReduction, Regression
Depends on: 111790
Blocks:
  Show dependency treegraph
 
Reported: 2013-04-13 09:29 PDT by David Kilzer (:ddkilzer)
Modified: 2018-09-05 15:39 PDT (History)
4 users (show)

See Also:


Attachments
Test case (144 bytes, text/html)
2013-04-13 09:29 PDT, David Kilzer (:ddkilzer)
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2013-04-13 09:29:37 PDT
Created attachment 197945 [details]
Test case

* SUMMARY
When refreshing a web page that has an overflowing console log, graphical glitches occur in the Web Inspector on nightly.webkit.org builds.

* STEPS TO REPRODUCE
1. Load attached test case in WebKit nightly build on Mac.
2. Open the Inspector (Cmd-Opt-I).
3. Click on the console to display it.
4. Reload the web page.

* RESULTS
Text overlaps in console (see attached screenshot).

* REGRESSION
This is a regression from commit r147261 which was the fix for Bug 111790.
<http://trac.webkit.org/changeset/147261>

* NOTES
This works as expected in WebKit nightly build r147249.
The bug starts occurring in WebKit nightly build r147268.
Comment 1 David Kilzer (:ddkilzer) 2013-04-13 09:30:58 PDT
Analysis from Tim Hatcher:
'''
min-height is defaulting to 0 now and not -webkit-min-content. However, putting min-height: -webkit-min-content on the element does not work. It seems -webkit-min-content only works on min-width?
'''
Comment 2 David Kilzer (:ddkilzer) 2013-04-13 09:31:23 PDT
<rdar://problem/13602668>
Comment 3 Ojan Vafai 2013-04-13 11:51:56 PDT
Another workaround that should work is setting -webkit-flex-shrink to 0. It's a bummer to change the API this late in the game, but I think the benefits still outweigh the cost.
Comment 4 Ojan Vafai 2013-04-13 11:55:02 PDT
Also, you may want to bring in https://chromium.googlesource.com/chromium/blink/+/5214cf3a1d0d78e880688ccd451e6145b9e69267 to make -webkit-min-content work on heights.