Bug 114557 - [CMake] Move NullPtr.cpp from PlatformWinCE.cmake to CMakeLists.txt
Summary: [CMake] Move NullPtr.cpp from PlatformWinCE.cmake to CMakeLists.txt
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-13 02:55 PDT by Patrick R. Gansterer
Modified: 2013-04-22 20:31 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.50 KB, patch)
2013-04-13 03:00 PDT, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2013-04-13 02:55:59 PDT 
[CMake] Move NullPtr.cpp from PlatformWinCE.cmake to CMakeLists.txt
Comment 1 Patrick R. Gansterer 2013-04-13 03:00:01 PDT 
Created attachment 197929 [details]
Patch
Comment 2 Brent Fulgham 2013-04-15 12:58:10 PDT 
Comment on attachment 197929 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=197929&action=review

> Source/WTF/wtf/CMakeLists.txt:178
> +    NullPtr.cpp

Is this not needed by any other platform build?  E.g., the Windows 2005 build (were it on CMake) would need this as well.
Comment 3 Patrick R. Gansterer 2013-04-15 16:21:29 PDT 
Comment on attachment 197929 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=197929&action=review

>> Source/WTF/wtf/CMakeLists.txt:178
>> +    NullPtr.cpp
> 
> Is this not needed by any other platform build?  E.g., the Windows 2005 build (were it on CMake) would need this as well.

now it is in the files for all compilers, so VS2005 will see it too
Comment 4 Laszlo Gombos 2013-04-22 20:05:28 PDT 
Comment on attachment 197929 [details]
Patch

r=me.
Comment 5 WebKit Commit Bot 2013-04-22 20:31:33 PDT 
Comment on attachment 197929 [details]
Patch

Clearing flags on attachment: 197929

Committed r148941: <http://trac.webkit.org/changeset/148941>
Comment 6 WebKit Commit Bot 2013-04-22 20:31:36 PDT 
All reviewed patches have been landed.  Closing bug.