RESOLVED FIXED 114557
[CMake] Move NullPtr.cpp from PlatformWinCE.cmake to CMakeLists.txt 
https://bugs.webkit.org/show_bug.cgi?id=114557
Summary [CMake] Move NullPtr.cpp from PlatformWinCE.cmake to CMakeLists.txt
Patrick R. Gansterer
Reported 2013-04-13 02:55:59 PDT
[CMake] Move NullPtr.cpp from PlatformWinCE.cmake to CMakeLists.txt
Attachments
Patch (1.50 KB, patch)
2013-04-13 03:00 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2013-04-13 03:00:01 PDT
Created attachment 197929 [details] Patch
Brent Fulgham
Comment 2 2013-04-15 12:58:10 PDT
Comment on attachment 197929 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=197929&action=review > Source/WTF/wtf/CMakeLists.txt:178 > + NullPtr.cpp Is this not needed by any other platform build? E.g., the Windows 2005 build (were it on CMake) would need this as well.
Patrick R. Gansterer
Comment 3 2013-04-15 16:21:29 PDT
Comment on attachment 197929 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=197929&action=review >> Source/WTF/wtf/CMakeLists.txt:178 >> + NullPtr.cpp > > Is this not needed by any other platform build? E.g., the Windows 2005 build (were it on CMake) would need this as well. now it is in the files for all compilers, so VS2005 will see it too
Laszlo Gombos
Comment 4 2013-04-22 20:05:28 PDT
Comment on attachment 197929 [details] Patch r=me.
WebKit Commit Bot
Comment 5 2013-04-22 20:31:33 PDT
Comment on attachment 197929 [details] Patch Clearing flags on attachment: 197929 Committed r148941: <http://trac.webkit.org/changeset/148941>
WebKit Commit Bot
Comment 6 2013-04-22 20:31:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.