Bug 114556 - [CMake] Add WTF_USE_*_UNICODE variables
Summary: [CMake] Add WTF_USE_*_UNICODE variables
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-13 02:47 PDT by Patrick R. Gansterer
Modified: 2013-04-15 22:56 PDT (History)
7 users (show)

See Also:


Attachments
Patch (11.18 KB, patch)
2013-04-13 02:52 PDT, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2013-04-13 02:47:06 PDT
[CMake] Add WTF_USE_*_UNICODE variables
Comment 1 Patrick R. Gansterer 2013-04-13 02:52:51 PDT
Created attachment 197928 [details]
Patch
Comment 2 Brent Fulgham 2013-04-15 12:59:17 PDT
Comment on attachment 197928 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2013-04-15 13:31:20 PDT
Comment on attachment 197928 [details]
Patch

Clearing flags on attachment: 197928

Committed r148463: <http://trac.webkit.org/changeset/148463>
Comment 4 WebKit Commit Bot 2013-04-15 13:31:22 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Ryosuke Niwa 2013-04-15 21:15:23 PDT
It seems like this patch broke Windows clean build:

http://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/47545/steps/compile-webkit/logs/stdio

13>WTF.lib(StringImpl.obj) : error LNK2019: unresolved external symbol _u_foldCase referenced in function "int __cdecl WTF::Unicode::foldCase(int)" (?foldCase@Unicode@WTF@@YAHH@Z)
13>WTF.lib(StringImpl.obj) : error LNK2019: unresolved external symbol _u_strFoldCase referenced in function "int __cdecl WTF::Unicode::foldCase(wchar_t *,int,wchar_t const *,int,bool *)" (?foldCase@Unicode@WTF@@YAHPA_WHPB_WHPA_N@Z)
13>WTF.lib(StringImpl.obj) : error LNK2019: unresolved external symbol _u_strToLower referenced in function "int __cdecl WTF::Unicode::toLower(wchar_t *,int,wchar_t const *,int,bool *)" (?toLower@Unicode@WTF@@YAHPA_WHPB_WHPA_N@Z)
13>WTF.lib(StringImpl.obj) : error LNK2019: unresolved external symbol _u_tolower referenced in function "int __cdecl WTF::Unicode::toLower(int)" (?toLower@Unicode@WTF@@YAHH@Z)
13>WTF.lib(StringImpl.obj) : error LNK2019: unresolved external symbol _u_toupper referenced in function "int __cdecl WTF::Unicode::toUpper(int)" (?toUpper@Unicode@WTF@@YAHH@Z)
13>WTF.lib(StringImpl.obj) : error LNK2019: unresolved external symbol _u_strToUpper referenced in function "int __cdecl WTF::Unicode::toUpper(wchar_t *,int,wchar_t const *,int,bool *)" (?toUpper@Unicode@WTF@@YAHPA_WHPB_WHPA_N@Z)
13>WTF.lib(StringImpl.obj) : error LNK2019: unresolved external symbol _u_charDirection referenced in function "enum WTF::Unicode::Direction __cdecl WTF::Unicode::direction(int)" (?direction@Unicode@WTF@@YA?AW4Direction@12@H@Z)
13>WTF.lib(WTFString.obj) : error LNK2001: unresolved external symbol _u_charDirection
13>WTF.lib(StringImpl.obj) : error LNK2019: unresolved external symbol _u_memcasecmp referenced in function "int __cdecl WTF::Unicode::umemcasecmp(wchar_t const *,wchar_t const *,int)" (?umemcasecmp@Unicode@WTF@@YAHPB_W0H@Z)
Comment 6 Patrick R. Gansterer 2013-04-15 22:56:29 PDT
(In reply to comment #5)
> It seems like this patch broke Windows clean build:
> 
> http://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/47545/steps/compile-webkit/logs/stdio

I don't think so, since this commit changed CMake files only and the Windows bots don't use CMake (yet).