Bug 114549 - Add private interface to WKView to asynchronously update the drawing area size
Summary: Add private interface to WKView to asynchronously update the drawing area size
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-12 17:39 PDT by Gavin Barraclough
Modified: 2013-04-12 18:36 PDT (History)
1 user (show)

See Also:


Attachments
Patch (8.88 KB, patch)
2013-04-12 17:44 PDT, Gavin Barraclough
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2013-04-12 17:39:01 PDT
This will allow a client using the WKView to resize the contents without blocking waiting for the web process to repaint.
Comment 1 Gavin Barraclough 2013-04-12 17:44:35 PDT
Created attachment 197915 [details]
Patch
Comment 2 Simon Fraser (smfr) 2013-04-12 18:07:36 PDT
Comment on attachment 197915 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=197915&action=review

> Source/WebKit2/UIProcess/API/mac/WKView.mm:3445
> +// The updated is performed asynchronously; we don't wait for the geometry update before returning.

The update

> Source/WebKit2/UIProcess/API/mac/WKView.mm:3464
> +        // If a geometry update is still pending then the action of recieving the

receiving

> Source/WebKit2/UIProcess/API/mac/WKView.mm:3468
> +        drawingArea->waitForPossibleGeometryUpdate();
> +        drawingArea->waitForPossibleGeometryUpdate();

Do we really want to wait for a whole second?
Comment 3 Gavin Barraclough 2013-04-12 18:36:46 PDT
Fixed in:
Committed revision 148331.