Bug 114544 - Block freeing thread should call Region::destroy instead of delete
Summary: Block freeing thread should call Region::destroy instead of delete
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-12 16:19 PDT by Mark Hahnenberg
Modified: 2013-04-12 16:43 PDT (History)
0 users

See Also:

Attachments
Patch (1.48 KB, patch)
2013-04-12 16:23 PDT, Mark Hahnenberg 		oliver: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2013-04-12 16:19:25 PDT 
Since Region doesn't have a virtual destructor, calling delete will not properly clean up all of the state of the Region. We should call destroy() instead.
Comment 1 Mark Hahnenberg 2013-04-12 16:23:43 PDT 
Created attachment 197907 [details]
Patch
Comment 2 Mark Hahnenberg 2013-04-12 16:41:52 PDT 
Committed r148314: <http://trac.webkit.org/changeset/148314>
Comment 3 Mark Hahnenberg 2013-04-12 16:43:48 PDT 
<rdar://problem/13260356>