RESOLVED FIXED 114538
Query directly for cache partition names
https://bugs.webkit.org/show_bug.cgi?id=114538
Summary Query directly for cache partition names
Vicki Pfau
Reported 2013-04-12 15:12:05 PDT
The heuristic used in WebKit currently for detecting cache partitions fails in a sizable number of cases. We should call back into the system to ask it for the names of the partitions instead.
Attachments
Patch (116.37 KB, patch)
2013-04-12 15:56 PDT, Vicki Pfau
ddkilzer: review+
Vicki Pfau
Comment 1 2013-04-12 15:56:11 PDT
David Kilzer (:ddkilzer)
Comment 2 2013-04-12 17:23:01 PDT
Comment on attachment 197898 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=197898&action=review r=me (Wow, that's a lot of indirection to get the list of origins.) > Source/WebKit2/WebProcess/ResourceCache/WebResourceCacheManager.cpp:59 > +#if USE(CFURLCACHE) > + __block > +#endif > MemoryCache::SecurityOriginSet origins; I think it would be clearer to write it this way: #if USE(CFURLCACHE) __block MemoryCache::SecurityOriginSet origins; #else MemoryCache::SecurityOriginSet origins; #endif Also, should the #if check be this since it's the only time that 'origins' is used in a block? #if USE(CFURLCACHE) && ENABLE(CACHE_PARTITIONING) __block MemoryCache::SecurityOriginSet origins; #else MemoryCache::SecurityOriginSet origins; #endif
Vicki Pfau
Comment 3 2013-04-12 17:25:42 PDT
(In reply to comment #2) > (From update of attachment 197898 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=197898&action=review > > r=me (Wow, that's a lot of indirection to get the list of origins.) > > > Source/WebKit2/WebProcess/ResourceCache/WebResourceCacheManager.cpp:59 > > +#if USE(CFURLCACHE) > > + __block > > +#endif > > MemoryCache::SecurityOriginSet origins; > > I think it would be clearer to write it this way: > > #if USE(CFURLCACHE) > __block MemoryCache::SecurityOriginSet origins; > #else > MemoryCache::SecurityOriginSet origins; > #endif I suppose it probably would be better style this way, yes. > Also, should the #if check be this since it's the only time that 'origins' is used in a block? > > #if USE(CFURLCACHE) && ENABLE(CACHE_PARTITIONING) > __block MemoryCache::SecurityOriginSet origins; > #else > MemoryCache::SecurityOriginSet origins; > #endif Hm, yeah, I must have missed that, but you're right.
Vicki Pfau
Comment 4 2013-04-12 18:08:44 PDT
Vicki Pfau
Comment 5 2013-04-12 18:09:38 PDT
Sam Weinig
Comment 6 2013-04-14 15:47:55 PDT
This should have been signed off by a WebKit2 owner. Please try to remember that in the future.
Note You need to log in before you can comment on or make changes to this bug.