Bug 114537 - [Mac] REGRESSION: Auto substitution strips new lines
Summary: [Mac] REGRESSION: Auto substitution strips new lines
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P1 Minor
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-04-12 15:01 PDT by Ryosuke Niwa
Modified: 2013-04-12 15:44 PDT (History)
5 users (show)

See Also:

Attachments
Fixes the bug (10.75 KB, patch)
2013-04-12 15:12 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Updated for ToT (10.75 KB, patch)
2013-04-12 15:17 PDT, Ryosuke Niwa 		enrica: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-04-12 15:01:10 PDT 
Reproduction steps:
1. Open Language & Text system preference
2. Setup "helloleworld" to be replaced by "hello
world" (copy paste it)
3. Type "helloleworld" into a content editable region or text fields.

Expected result:
"helloleworld" is replaced by "hello
world"

Actual result:
"helloleworld" is replaced by "hello world".
Comment 1 Ryosuke Niwa 2013-04-12 15:01:32 PDT 
<rdar://problem/12656747>
Comment 2 Ryosuke Niwa 2013-04-12 15:12:57 PDT 
Created attachment 197893 [details]
Fixes the bug
Comment 3 Ryosuke Niwa 2013-04-12 15:17:12 PDT 
Created attachment 197894 [details]
Updated for ToT
Comment 4 Enrica Casucci 2013-04-12 15:41:12 PDT 
Comment on attachment 197894 [details]
Updated for ToT

View in context: https://bugs.webkit.org/attachment.cgi?id=197894&action=review

Look good.

> Source/WebCore/ChangeLog:12
> +        CompositeEditCommand::apply after SpellingCorrectionCommand::doApply. So replaced the check in apply

So I replaced
Comment 5 Ryosuke Niwa 2013-04-12 15:43:39 PDT 
Comment on attachment 197894 [details]
Updated for ToT

View in context: https://bugs.webkit.org/attachment.cgi?id=197894&action=review

>> Source/WebCore/ChangeLog:12
>> +        CompositeEditCommand::apply after SpellingCorrectionCommand::doApply. So replaced the check in apply
> 
> So I replaced

Did s/So replaced/Replaced/ to match the sentence style elsewhere.
Comment 6 Ryosuke Niwa 2013-04-12 15:44:31 PDT 
Committed r148306: <http://trac.webkit.org/changeset/148306>