Bug 114532 – Rename StyleBuilder to DeprecatedStyleBuilder

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Dirk Schulze]

Rename StyleBuilder to DeprecatedStyleBuilder to clarify that new properties should not go into the template handling system.

Note that the discussion is still ongoing on webkit-dev. The bug might be invalid at the end of the discussion.

[Dirk Schulze]

Created attachment 197884 [details]
Patch

[Benjamin Poulain]

Comment on attachment 197884 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=197884&action=review

> Source/WebCore/ChangeLog:8
> +        The StyleBuilder code is hard to read and maintain. People sould

sould -> should

[Benjamin Poulain]

Comment on attachment 197884 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=197884&action=review

> Source/WebCore/css/DeprecatedStyleBuilder.cpp:2
> + * Copyright (C) 2011 Google Inc. All rights reserved.

I think someone messed up with the copyright at some point.
Most of that code was moved, not authored by google.

[WebKit Commit Bot]

Attachment 197884 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.vcproj/WebCore.vcproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/css/CSSAllInOne.cpp', u'Source/WebCore/css/DeprecatedStyleBuilder.cpp', u'Source/WebCore/css/DeprecatedStyleBuilder.h', u'Source/WebCore/css/StyleBuilder.cpp', u'Source/WebCore/css/StyleBuilder.h', u'Source/WebCore/css/StyleResolver.cpp', u'Source/WebCore/css/StyleResolver.h', u'Source/WebCore/rendering/style/RenderStyle.h']" exit_code: 1
Source/WebCore/css/DeprecatedStyleBuilder.cpp:277:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/css/DeprecatedStyleBuilder.cpp:278:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/css/DeprecatedStyleBuilder.cpp:279:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/css/DeprecatedStyleBuilder.cpp:280:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/css/DeprecatedStyleBuilder.cpp:281:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/css/DeprecatedStyleBuilder.cpp:347:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/css/DeprecatedStyleBuilder.cpp:348:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/css/DeprecatedStyleBuilder.cpp:349:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/css/DeprecatedStyleBuilder.cpp:350:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/css/DeprecatedStyleBuilder.cpp:351:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/css/DeprecatedStyleBuilder.cpp:352:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/css/DeprecatedStyleBuilder.cpp:353:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/css/DeprecatedStyleBuilder.cpp:494:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/css/DeprecatedStyleBuilder.cpp:495:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/css/DeprecatedStyleBuilder.cpp:496:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/css/DeprecatedStyleBuilder.cpp:497:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/css/DeprecatedStyleBuilder.cpp:498:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/css/DeprecatedStyleBuilder.cpp:499:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/css/DeprecatedStyleBuilder.cpp:500:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/css/DeprecatedStyleBuilder.cpp:501:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/css/DeprecatedStyleBuilder.cpp:502:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/css/DeprecatedStyleBuilder.cpp:503:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/css/DeprecatedStyleBuilder.cpp:549:  Omit int when using unsigned  [runtime/unsigned] [1]
Source/WebCore/css/DeprecatedStyleBuilder.cpp:577:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/css/DeprecatedStyleBuilder.cpp:578:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/css/DeprecatedStyleBuilder.cpp:579:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/css/DeprecatedStyleBuilder.cpp:580:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/css/DeprecatedStyleBuilder.cpp:581:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/css/DeprecatedStyleBuilder.cpp:582:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/css/DeprecatedStyleBuilder.cpp:866:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/css/DeprecatedStyleBuilder.cpp:1010:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/css/DeprecatedStyleBuilder.cpp:1011:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/css/DeprecatedStyleBuilder.cpp:1012:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/css/DeprecatedStyleBuilder.cpp:1132:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/css/DeprecatedStyleBuilder.cpp:1134:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/css/DeprecatedStyleBuilder.cpp:1173:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/css/DeprecatedStyleBuilder.cpp:1175:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/css/DeprecatedStyleBuilder.cpp:1633:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/css/DeprecatedStyleBuilder.cpp:1634:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/css/DeprecatedStyleBuilder.cpp:1635:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/css/DeprecatedStyleBuilder.cpp:1636:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/css/DeprecatedStyleBuilder.cpp:1637:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/css/DeprecatedStyleBuilder.cpp:1638:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/css/DeprecatedStyleBuilder.cpp:1639:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/css/DeprecatedStyleBuilder.cpp:1640:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/css/DeprecatedStyleBuilder.cpp:1930:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/css/DeprecatedStyleBuilder.cpp:2230:  Omit int when using unsigned  [runtime/unsigned] [1]
Source/WebCore/css/DeprecatedStyleBuilder.cpp:2232:  Omit int when using unsigned  [runtime/unsigned] [1]
Total errors found: 48 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dirk Schulze]

(In reply to comment #3)
> (From update of attachment 197884 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=197884&action=review
> 
> > Source/WebCore/css/DeprecatedStyleBuilder.cpp:2
> > + * Copyright (C) 2011 Google Inc. All rights reserved.
> 
> I think someone messed up with the copyright at some point.
> Most of that code was moved, not authored by google.

That might be. I'll hold on on landing this patch. It seems like Antti and rniwa have some more ideas and I want to check that first. See bug 114508

[Dirk Schulze]

Created attachment 197949 [details]
Patch for landing.

Land patch.

[WebKit Commit Bot]

Comment on attachment 197949 [details]
Patch for landing.

Clearing flags on attachment: 197949

Committed r148363: <http://trac.webkit.org/changeset/148363>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.