Make CodeGeneratorJS plant comments to explain failures in the binding validation
Created attachment 197878 [details] Patch
Committed r148301: <http://trac.webkit.org/changeset/148301>
Comment on attachment 197878 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=197878&action=review r=me > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:2758 > push(@implContent, <<END) if $interface->extendedAttributes->{"ImplementationLacksVTable"} && $vtableNameGnu; > #if COMPILER(CLANG) > - COMPILE_ASSERT(!__is_polymorphic($implType), ${implType}_is_polymorphic_but_idl_claims_not_to_be); > + // If you hit this failure the interface definition has the ImplementationLacksVTable > + // attribute. You should remove that attribute. If the class has subclasses > + // that may be passed through this toJS() function you should use the SkipVTableValidation > + // attribute to $interfaceName. > + COMPILE_ASSERT(!__is_polymorphic($implType), ${implType}_is_polymorphic_but_idl_claims_not_to_be); > #endif > END The bindings test scripts don't appear to cover this test case. Might be something we want to add in the future.