WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
114528
Make CodeGeneratorJS plant comments to explain failures in the binding validation
https://bugs.webkit.org/show_bug.cgi?id=114528
Summary
Make CodeGeneratorJS plant comments to explain failures in the binding valida...
Oliver Hunt
Reported
2013-04-12 13:12:10 PDT
Make CodeGeneratorJS plant comments to explain failures in the binding validation
Attachments
Patch
(19.68 KB, patch)
2013-04-12 13:13 PDT
,
Oliver Hunt
sam
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Oliver Hunt
Comment 1
2013-04-12 13:13:12 PDT
Created
attachment 197878
[details]
Patch
Oliver Hunt
Comment 2
2013-04-12 13:27:27 PDT
Committed
r148301
: <
http://trac.webkit.org/changeset/148301
>
David Kilzer (:ddkilzer)
Comment 3
2013-04-12 13:27:56 PDT
Comment on
attachment 197878
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=197878&action=review
r=me
> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:2758 > push(@implContent, <<END) if $interface->extendedAttributes->{"ImplementationLacksVTable"} && $vtableNameGnu; > #if COMPILER(CLANG) > - COMPILE_ASSERT(!__is_polymorphic($implType), ${implType}_is_polymorphic_but_idl_claims_not_to_be); > + // If you hit this failure the interface definition has the ImplementationLacksVTable > + // attribute. You should remove that attribute. If the class has subclasses > + // that may be passed through this toJS() function you should use the SkipVTableValidation > + // attribute to $interfaceName. > + COMPILE_ASSERT(!__is_polymorphic($implType), ${implType}_is_polymorphic_but_idl_claims_not_to_be); > #endif > END
The bindings test scripts don't appear to cover this test case. Might be something we want to add in the future.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug