Bug 114525 - r148197 broke the GTK+ build
Summary: r148197 broke the GTK+ build
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 523.x (Safari 3)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
: 114545 (view as bug list)
Depends on:
Reported: 2013-04-12 11:48 PDT by Martin Robinson
Modified: 2013-04-12 17:02 PDT (History)
12 users (show)

See Also:

Patch (10.53 KB, patch)
2013-04-12 12:24 PDT, Martin Robinson
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2013-04-12 11:48:37 PDT
Removing the guards on the threaded scrolling code both potentially increased the code size for configurations that don't use it and broke the build for ports that don't have an implementation of the scrolling tree.
Comment 1 Martin Robinson 2013-04-12 12:24:24 PDT
Created attachment 197876 [details]
Comment 2 Anders Carlsson 2013-04-12 12:32:01 PDT
Comment on attachment 197876 [details]

It's unfortunate that this has to added, but it's OK for now. (Ideally I'd like to see all ports use the scrolling state stuff).
Comment 3 Martin Robinson 2013-04-12 12:34:07 PDT
Committed r148298: <http://trac.webkit.org/changeset/148298>
Comment 4 Martin Robinson 2013-04-12 17:02:03 PDT
*** Bug 114545 has been marked as a duplicate of this bug. ***