Bug 114520 - [GTK] Lower the pango dependency
Summary: [GTK] Lower the pango dependency
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 523.x (Safari 3)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-12 10:58 PDT by Martin Robinson
Modified: 2013-04-12 11:43 PDT (History)
1 user (show)

See Also:

Attachments
Patch (1.20 KB, patch)
2013-04-12 11:00 PDT, Martin Robinson 		cgarcia: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2013-04-12 10:58:36 PDT 
For WebKitGTK+ 2.0 we accidentally raised the Pango dependency higher than the version required by GTK+ 3.6. Since GTK+ 3.6 is the version of GTK+ that we depend on, we don't need to depend on such a new version of Pango.
Comment 1 Martin Robinson 2013-04-12 11:00:17 PDT 
Created attachment 197869 [details]
Patch
Comment 2 Carlos Garcia Campos 2013-04-12 11:03:02 PDT 
(In reply to comment #0)
> For WebKitGTK+ 2.0 we accidentally raised the Pango dependency higher than the version required by GTK+ 3.6. Since GTK+ 3.6 is the version of GTK+ that we depend on, we don't need to depend on such a new version of Pango.

I was not accidentally, we raised it because it was the current stable (now it's 1.34), and the first one depending on hafbuzz which we depdend on now too. See the thread in the mailing list. I'm not saying I'm opposed to lower the dependency if it's causing trouble to people, though.
Comment 3 Carlos Garcia Campos 2013-04-12 11:05:35 PDT 
Comment on attachment 197869 [details]
Patch

You could explain why in the ChangeLog, btw
Comment 4 Martin Robinson 2013-04-12 11:11:53 PDT 
(In reply to comment #2)
> (In reply to comment #0)
> > For WebKitGTK+ 2.0 we accidentally raised the Pango dependency higher than the version required by GTK+ 3.6. Since GTK+ 3.6 is the version of GTK+ that we depend on, we don't need to depend on such a new version of Pango.
> 
> I was not accidentally, we raised it because it was the current stable (now it's 1.34), and the first one depending on hafbuzz which we depdend on now too. See the thread in the mailing list. I'm not saying I'm opposed to lower the dependency if it's causing trouble to people, though.

There was a bit of accidentalality on my part, at least.
Comment 5 Martin Robinson 2013-04-12 11:43:41 PDT 
Committed r148293: <http://trac.webkit.org/changeset/148293>