Bug 114515 - [BlackBerry] Enable selecting text in single line input field without selection point being actually on the targeted text vertically
Summary: [BlackBerry] Enable selecting text in single line input field without selecti...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-12 08:52 PDT by Yongxin Dai
Modified: 2013-04-12 13:43 PDT (History)
4 users (show)

See Also:

Attachments
Patch (6.33 KB, patch)
2013-04-12 09:09 PDT, Yongxin Dai 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yongxin Dai 2013-04-12 08:52:25 PDT 
It is still hard to select text in URL bar with an inverted selection handle.  We can improve the issue by replacing the Y coordinate of selection point with Y coordinate of start caret for single line input filed.  Thus, the Y coordinate is always valid regardless of the actual location of the selection handle.
Comment 1 Yongxin Dai 2013-04-12 09:09:10 PDT 
Created attachment 197857 [details]
Patch
Comment 2 Rob Buis 2013-04-12 13:12:23 PDT 
Comment on attachment 197857 [details]
Patch

LGTM.
Comment 3 WebKit Commit Bot 2013-04-12 13:43:13 PDT 
Comment on attachment 197857 [details]
Patch

Clearing flags on attachment: 197857

Committed r148302: <http://trac.webkit.org/changeset/148302>
Comment 4 WebKit Commit Bot 2013-04-12 13:43:14 PDT 
All reviewed patches have been landed.  Closing bug.