RESOLVED FIXED 114512
[Qt][Win] r148257 broke the build 
https://bugs.webkit.org/show_bug.cgi?id=114512
Summary [Qt][Win] r148257 broke the build
Zoltan Arvai
Reported 2013-04-12 07:08:35 PDT
After r148257 Qt Win build is broken. Maybe related to toJS changes, too. http://build.webkit.org/builders/Qt%20Windows%2032-bit%20Release/builds/64072/steps/compile-webkit/logs/stdio WebCore.lib(JSNotification.obj) : error LNK2019: unresolved external symbol __ZTVN7WebCore12NotificationE referenced in function "class JSC::JSValue __cdecl WebCore::toJS(class JSC::ExecState *,class WebCore::JSDOMGlobalObject *,class WebCore::Notification *)" (?toJS@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@PAVJSDOMGlobalObject@1@PAVNotification@1@@Z) WebCore.lib(JSInternals.obj) : error LNK2019: unresolved external symbol __ZTVN7WebCore9InternalsE referenced in function "class JSC::JSValue __cdecl WebCore::toJS(class JSC::ExecState *,class WebCore::JSDOMGlobalObject *,class WebCore::Internals *)" (?toJS@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@PAVJSDOMGlobalObject@1@PAVInternals@1@@Z) WebCore.lib(JSDOMSelection.obj) : error LNK2019: unresolved external symbol __ZTVN7WebCore12DOMSelectionE referenced in function "class JSC::JSValue __cdecl WebCore::toJS(class JSC::ExecState *,class WebCore::JSDOMGlobalObject *,class WebCore::DOMSelection *)" (?toJS@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@PAVJSDOMGlobalObject@1@PAVDOMSelection@1@@Z) ...
Attachments
Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2013-04-12 09:17:36 PDT
Committed r148280: <http://trac.webkit.org/changeset/148280>
Jocelyn Turcotte
Comment 2 2013-04-12 09:30:08 PDT
(In reply to comment #1) > Committed r148280: <http://trac.webkit.org/changeset/148280> #if PLATFORM(MAC) || PLATFORM(BLACKBERRY) -#define WTF_USE_REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR 1 +#define BINDING_INTEGRITY 1 #endif Maybe this should be "ENABLE_BINDING_INTEGRITY" instead?
Oliver Hunt
Comment 3 2013-04-12 10:35:56 PDT
(In reply to comment #2) > (In reply to comment #1) > > Committed r148280: <http://trac.webkit.org/changeset/148280> > > #if PLATFORM(MAC) || PLATFORM(BLACKBERRY) > -#define WTF_USE_REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR 1 > +#define BINDING_INTEGRITY 1 > #endif > > Maybe this should be "ENABLE_BINDING_INTEGRITY" instead? whoah, that's an entirely bogus change, thanks for spotting it. O_o
Csaba Osztrogonác
Comment 4 2013-04-14 00:47:52 PDT
Reopen, because it didn't fix anything, the build is still broken.
Oliver Hunt
Comment 5 2013-04-14 09:47:38 PDT
(In reply to comment #4) > Reopen, because it didn't fix anything, the build is still broken. Does QT set PLATFORM(WIN) ?
Csaba Osztrogonác
Comment 6 2013-04-14 23:38:39 PDT
(In reply to comment #5) > (In reply to comment #4) > > Reopen, because it didn't fix anything, the build is still broken. > > Does QT set PLATFORM(WIN) ? No, but OS(WIN). Thanks for http://trac.webkit.org/changeset/148405 , it fixed the build.
Oliver Hunt
Comment 7 2013-04-14 23:51:43 PDT
Yay! Sorry for the delay. Seems icky to bludgeon out windows, but i think i need to do a bit more work to make binding generation windows friendly.
Note You need to log in before you can comment on or make changes to this bug.