Bug 114501 – AnimationController: set timer delay to 0.016 in the BlackBerry port

• Status: RESOLVED
• Resolution: INVALID
• Component: WebCore Misc.

[Alberto Garcia]

The BlackBerry is set to 60fps instead of 40.

[Alberto Garcia]

Created attachment 197741 [details]
Patch

This would be the trivial option, but I think anilsson has a better proposal, can you comment?

[Alberto Garcia]

Updating bug title since it affects cross-platform code.

[Arvid Nilsson]

The thing I told berto about was: Another approach we have been discussing at BlackBerry is to hook up the AnimationController to the requestAnimationFrame mechanism. Then it would not have to use a Timer at all, and wouldn't have to hard code any timeout.

It would perhaps be good if we could prioritize the tasks performed when RAF fires, so that JS handlers fire first (so they can start/stop animations, modify DOM etc) and then the AnimationController gets to run its native handlers.

[Arvid Nilsson]

CC'ing Simon for his input

[Simon Fraser (smfr)]

AnimationController does use requestAnimationFrame for CSS animations: bug 64591, if the platform supports them.

[Arvid Nilsson]

(In reply to comment #5)
> AnimationController does use requestAnimationFrame for CSS animations: bug 64591, if the platform supports them.

Thank you very much Simon - that's very useful! We can drop our local timer timeout tweak as soon as we pick up the fix for 64591.

Marking this as invalid.

[Arvid Nilsson]

(In reply to comment #3)
> The thing I told berto about was: Another approach we have been discussing at BlackBerry is to hook up the AnimationController to the requestAnimationFrame mechanism. Then it would not have to use a Timer at all, and wouldn't have to hard code any timeout.
> 
> It would perhaps be good if we could prioritize the tasks performed when RAF fires, so that JS handlers fire first (so they can start/stop animations, modify DOM etc) and then the AnimationController gets to run its native handlers.

It's interesting to see that the developers on bug #64591 chose to let the AnimationController animations fire first, and only then service JS animations. I'm sure there's good arguments for doing it that way around, too.