RESOLVED FIXED 114494
webkitbot should provide full name, email address, and IRC nicknames on whois 
https://bugs.webkit.org/show_bug.cgi?id=114494
Summary webkitbot should provide full name, email address, and IRC nicknames on whois
Ryosuke Niwa
Reported 2013-04-12 00:09:41 PDT
webkitbot should provide full name, email address, and IRC nicknames on whois
Attachments
Fixes the bug (9.41 KB, patch)
2013-04-12 00:12 PDT, Ryosuke Niwa 		benjamin: review+
benjamin: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2013-04-12 00:12:27 PDT
Created attachment 197726 [details] Fixes the bug
Benjamin Poulain
Comment 2 2013-04-12 00:55:50 PDT
Comment on attachment 197726 [details] Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=197726&action=review > Tools/Scripts/webkitpy/tool/bot/irc_command.py:285 > + return "%s: %s is %s. Why do you ask?" % (nick, search_string, self._full_record_and_nick(contributor)) Shouldn't this be a unicode string too to avoid borking non-latin1 names? (for Tor Arne for example). I think Account also need __unicode__. From a quick look, it seems it only has __str__. > Tools/Scripts/webkitpy/tool/bot/irc_command.py:288 > return "%s: I'm not sure who you mean? %s could be '%s'." % (nick, contributors_string, search_string) ditto. > Tools/Scripts/webkitpy/tool/bot/irc_command_unittest.py:45 > whois = Whois() > self.assertEqual("tom: Usage: whois SEARCH_STRING", > whois.execute("tom", [], None, None)) > - self.assertEqual("tom: Adam Barth is abarth (abarth@webkit.org). Why do you ask?", > + self.assertEqual('tom: Adam Barth is "Adam Barth" <abarth@webkit.org> (:abarth) (r). Why do you ask?', [...] need a test for uncommon characters in names.
Ryosuke Niwa
Comment 3 2013-04-13 17:44:53 PDT
Committed r148372: <http://trac.webkit.org/changeset/148372>
Note You need to log in before you can comment on or make changes to this bug.