Bug 114494 - webkitbot should provide full name, email address, and IRC nicknames on whois
Summary: webkitbot should provide full name, email address, and IRC nicknames on whois
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-12 00:09 PDT by Ryosuke Niwa
Modified: 2013-04-13 17:44 PDT (History)
5 users (show)

See Also:


Attachments
Fixes the bug (9.41 KB, patch)
2013-04-12 00:12 PDT, Ryosuke Niwa
benjamin: review+
benjamin: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-04-12 00:09:41 PDT
webkitbot should provide full name, email address, and IRC nicknames on whois
Comment 1 Ryosuke Niwa 2013-04-12 00:12:27 PDT
Created attachment 197726 [details]
Fixes the bug
Comment 2 Benjamin Poulain 2013-04-12 00:55:50 PDT
Comment on attachment 197726 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=197726&action=review

> Tools/Scripts/webkitpy/tool/bot/irc_command.py:285
> +            return "%s: %s is %s. Why do you ask?" % (nick, search_string, self._full_record_and_nick(contributor))

Shouldn't this be a unicode string too to avoid borking non-latin1 names? (for Tor Arne for example).

I think Account also need __unicode__. From a quick look, it seems it only has __str__.

> Tools/Scripts/webkitpy/tool/bot/irc_command.py:288
>          return "%s: I'm not sure who you mean?  %s could be '%s'." % (nick, contributors_string, search_string)

ditto.

> Tools/Scripts/webkitpy/tool/bot/irc_command_unittest.py:45
>          whois = Whois()
>          self.assertEqual("tom: Usage: whois SEARCH_STRING",
>                            whois.execute("tom", [], None, None))
> -        self.assertEqual("tom: Adam Barth is abarth (abarth@webkit.org). Why do you ask?",
> +        self.assertEqual('tom: Adam Barth is "Adam Barth" <abarth@webkit.org> (:abarth) (r). Why do you ask?',

[...] need a test for uncommon characters in names.
Comment 3 Ryosuke Niwa 2013-04-13 17:44:53 PDT
Committed r148372: <http://trac.webkit.org/changeset/148372>