Bug 114484 – Add support for MediaPlayer::minTimeSeekable()

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jer Noble]

Add support for MediaPlayer::minTimeSeekable()

[Jer Noble]

Created attachment 197705 [details]
Patch

[Jer Noble]

Created attachment 197713 [details]
Patch

Fixed windows build errors by adding symbols needed by WebCoreTestSupport to exports list.

[Jer Noble]

Wrong bug; disregard attachment 197713 [details].

[Build Bot]

Comment on attachment 197705 [details]
Patch

Attachment 197705 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/132008

New failing tests:
media/video-seek-past-end-paused.html

[Build Bot]

Created attachment 197734 [details]
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-02  Port: mac-mountainlion  Platform: Mac OS X 10.8.2

[Build Bot]

Comment on attachment 197705 [details]
Patch

Attachment 197705 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/81201

New failing tests:
media/video-seek-past-end-paused.html

[Build Bot]

Created attachment 197735 [details]
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-03  Port: mac-mountainlion  Platform: Mac OS X 10.8.2

[Jer Noble]

The test failures will be fixed by bug #114483.  Marking this bug as dependent on that one.

[Eric Carlson]

Comment on attachment 197705 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=197705&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:696
> +    double minTimeSeekable = std::numeric_limits<double>::infinity();
> +    for (NSValue *thisRangeValue in seekableRanges) {
> +        CMTimeRange timeRange = [thisRangeValue CMTimeRangeValue];
> +        if (!CMTIMERANGE_IS_VALID(timeRange) || CMTIMERANGE_IS_EMPTY(timeRange))
> +            continue;
> +
> +        double startOfRange = CMTimeGetSeconds(timeRange.start);
> +        if (minTimeSeekable > startOfRange)
> +            minTimeSeekable = startOfRange;
> +    }
> +    return minTimeSeekable;

infinity() is probably not the right value to return if seekableRanges is not empty, but does not have any valid ranges. Definitely an edge case, but probably worth special casing.

[Jer Noble]

Created attachment 197864 [details]
Patch

Return a 0 from platformMinTimeSeekable() if -seekableTimeRanges have no valid ranges.

[Jer Noble]

Committed r148291: <http://trac.webkit.org/changeset/148291>