Bug 114462 - Cannot scroll to footer on a page with overflow:hidden on the body
Summary: Cannot scroll to footer on a page with overflow:hidden on the body
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Beth Dakin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-04-11 13:45 PDT by Beth Dakin
Modified: 2013-04-11 14:00 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.89 KB, patch)
2013-04-11 13:51 PDT, Beth Dakin 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2013-04-11 13:45:30 PDT 
If a WKView has a header/footer, you cannot scroll to the footer if the page has overflow:hidden on the body.

<rdar://problem/13530042>
Comment 1 Beth Dakin 2013-04-11 13:51:30 PDT 
Created attachment 197668 [details]
Patch
Comment 2 Simon Fraser (smfr) 2013-04-11 13:56:26 PDT 
Comment on attachment 197668 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=197668&action=review

> Source/WebCore/page/FrameView.cpp:614
> +        || (m_frame->page() && m_frame->page()->mainFrame() == m_frame && (headerHeight() || footerHeight()));

Why don't we have Frame::isMainFrame()? :(
Comment 3 Beth Dakin 2013-04-11 14:00:17 PDT 
(In reply to comment #2)
> (From update of attachment 197668 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=197668&action=review
> 
> > Source/WebCore/page/FrameView.cpp:614
> > +        || (m_frame->page() && m_frame->page()->mainFrame() == m_frame && (headerHeight() || footerHeight()));
> 
> Why don't we have Frame::isMainFrame()? :(

We REALLY should add this. 

http://trac.webkit.org/changeset/148234