Bug 114460 – Support "forced" subtitles

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Eric Carlson]

Add support for forced subtitles. This patch uses the preliminary "forced" @kind value as proposed to the WhatWG mailing list [1] and a HTML5 spec bug [2]. Most of this patch is agnostic to this issue, so if it turns out that the proposal is not accepted, only the @kind value will need to be changed.

[1] http://lists.whatwg.org/pipermail/whatwg-whatwg.org/2013-April/039374.html
[2] https://www.w3.org/Bugs/Public/show_bug.cgi?id=21667

[Eric Carlson]

Created attachment 197665 [details]
Proposed patch

Note: the new test added with this patch will not pass the bots because including the new media file in the patch makes it to large to attach. I will submit the new movie with the rest of the changes.

[WebKit Commit Bot]

Attachment 197665 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/media/track/track-forced-subtitles-in-band-expected.txt', u'LayoutTests/media/track/track-forced-subtitles-in-band.html', u'LayoutTests/media/trackmenu-test.js', u'LayoutTests/platform/efl/TestExpectations', u'LayoutTests/platform/gtk/TestExpectations', u'LayoutTests/platform/mac/TestExpectations', u'LayoutTests/platform/qt/TestExpectations', u'LayoutTests/platform/win/TestExpectations', u'Source/WebCore/ChangeLog', u'Source/WebCore/html/HTMLMediaElement.cpp', u'Source/WebCore/html/track/InbandTextTrack.cpp', u'Source/WebCore/html/track/TextTrack.cpp', u'Source/WebCore/html/track/TextTrack.h', u'Source/WebCore/page/CaptionUserPreferences.cpp', u'Source/WebCore/page/CaptionUserPreferences.h', u'Source/WebCore/page/CaptionUserPreferencesMac.mm', u'Source/WebCore/platform/graphics/InbandTextTrackPrivate.h', u'Source/WebCore/platform/graphics/PlatformTextTrack.h', u'Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp', u'Source/WebCore/platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm', u'Source/WebCore/testing/Internals.cpp', u'Source/WebCore/testing/Internals.h', u'Source/WebCore/testing/Internals.idl']" exit_code: 1
Source/WebCore/platform/graphics/InbandTextTrackPrivate.h:53:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/WebCore/platform/graphics/InbandTextTrackPrivate.h:62:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/WebCore/platform/graphics/PlatformTextTrack.h:50:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/WebCore/platform/graphics/PlatformTextTrack.h:59:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 4 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Eric Carlson]

Created attachment 197669 [details]
Updated patch.

Note: the new test added with this patch will not pass the bots because including the new media file in the patch makes it to large to attach. I will submit the new movie with the rest of the changes.

[Eric Carlson]

<rdar://13376059>

[Eric Carlson]

https://trac.webkit.org/r148285