Bug 114451 - Implement more logic in StorageAreaMap
Summary: Implement more logic in StorageAreaMap
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-11 10:05 PDT by Anders Carlsson
Modified: 2013-04-11 10:42 PDT (History)
3 users (show)

See Also:

Attachments
Patch (19.31 KB, patch)
2013-04-11 10:23 PDT, Anders Carlsson 		ap: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2013-04-11 10:05:22 PDT 
Implement more logic in StorageAreaMap
Comment 1 Anders Carlsson 2013-04-11 10:23:12 PDT 
Created attachment 197638 [details]
Patch
Comment 2 Alexey Proskuryakov 2013-04-11 10:35:37 PDT 
Comment on attachment 197638 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=197638&action=review

> Source/WebKit2/UIProcess/Storage/StorageManager.cpp:101
> +        // FIXME: If this is sent to another process, the source storage area won't make sense.

I don't understand this comment. What another process? Is this for the case when a process is restarted after a crash?

Please elaborate, unless you plan to address this very soon.

> Source/WebKit2/WebProcess/Storage/StorageAreaMap.cpp:133
> +    // FIXME: This should use a special sendSync flag to indicate that we don't want to process incoming messages while waiting for a reply.
> +    // (This flag does not yet exist).

It's not very obvious why.
Comment 3 Anders Carlsson 2013-04-11 10:42:48 PDT 
Committed r148215: <http://trac.webkit.org/changeset/148215>