WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
114451
Implement more logic in StorageAreaMap
https://bugs.webkit.org/show_bug.cgi?id=114451
Summary
Implement more logic in StorageAreaMap
Anders Carlsson
Reported
2013-04-11 10:05:22 PDT
Implement more logic in StorageAreaMap
Attachments
Patch
(19.31 KB, patch)
2013-04-11 10:23 PDT
,
Anders Carlsson
ap
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2013-04-11 10:23:12 PDT
Created
attachment 197638
[details]
Patch
Alexey Proskuryakov
Comment 2
2013-04-11 10:35:37 PDT
Comment on
attachment 197638
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=197638&action=review
> Source/WebKit2/UIProcess/Storage/StorageManager.cpp:101 > + // FIXME: If this is sent to another process, the source storage area won't make sense.
I don't understand this comment. What another process? Is this for the case when a process is restarted after a crash? Please elaborate, unless you plan to address this very soon.
> Source/WebKit2/WebProcess/Storage/StorageAreaMap.cpp:133 > + // FIXME: This should use a special sendSync flag to indicate that we don't want to process incoming messages while waiting for a reply. > + // (This flag does not yet exist).
It's not very obvious why.
Anders Carlsson
Comment 3
2013-04-11 10:42:48 PDT
Committed
r148215
: <
http://trac.webkit.org/changeset/148215
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug