Bug 114428 - [Qt] EventHandler should handle Space and BackSpace
Summary: [Qt] EventHandler should handle Space and BackSpace
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Allan Sandfeld Jensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-11 02:54 PDT by Allan Sandfeld Jensen
Modified: 2013-04-11 04:44 PDT (History)
6 users (show)

See Also:


Attachments
Patch (6.98 KB, patch)
2013-04-11 02:56 PDT, Allan Sandfeld Jensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Allan Sandfeld Jensen 2013-04-11 02:54:22 PDT
WebCore's eventhandler has code to handle space and backspace key-presses. Qt should use those instead of handling them in our own WK1 or WK2 event handling code.
Comment 1 Allan Sandfeld Jensen 2013-04-11 02:56:08 PDT
Created attachment 197546 [details]
Patch
Comment 2 Jocelyn Turcotte 2013-04-11 03:19:33 PDT
The code LGTM but I'd like to know if Simon think of anything this patch could break.
Comment 3 Jocelyn Turcotte 2013-04-11 03:27:42 PDT
Comment on attachment 197546 [details]
Patch

r=me in any case, the risk is low
Comment 4 Simon Hausmann 2013-04-11 03:55:27 PDT
I can't think of anything, so LGTM :)
Comment 5 WebKit Commit Bot 2013-04-11 04:43:27 PDT
The commit-queue encountered the following flaky tests while processing attachment 197546 [details]:

svg/as-image/img-preserveAspectRatio-support-2.html bug 114434 (author: zimmermann@kde.org)
The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2013-04-11 04:44:53 PDT
Comment on attachment 197546 [details]
Patch

Clearing flags on attachment: 197546

Committed r148195: <http://trac.webkit.org/changeset/148195>
Comment 7 WebKit Commit Bot 2013-04-11 04:44:56 PDT
All reviewed patches have been landed.  Closing bug.