Bug 114414 – [CSS Shaders] Parse mix descriptor

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Dirk Schulze]

Parse mix descriptor on @filter rule.

[Dirk Schulze]

Created attachment 197511 [details]
Patch

[Antti Koivisto]

Comment on attachment 197511 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=197511&action=review

> Source/WebCore/ChangeLog:9
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Add support for the 'mix' descriptor to support blend modes and composite
> +        operators in CSS Shaders.

A brief description of what it does would be nice. You should also include a link to the spec.

[Antti Koivisto]

Comment on attachment 197511 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=197511&action=review

> Source/WebCore/css/CSSParser.cpp:2357
> +        if (m_inFilterRule)
> +            return parseFilterRuleMix();
> +        return false;

I would do early return on exception.

if (!m_inFilterRule) 
    return false;
...

[Dirk Schulze]

Created attachment 197589 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 197589 [details]
Patch

Rejecting attachment 197589 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--non-interactive', 197589, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-commit-queue.appspot.com/results/17638084

[Dirk Schulze]

Created attachment 197590 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 197590 [details]
Patch

Clearing flags on attachment: 197590

Committed r148205: <http://trac.webkit.org/changeset/148205>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.