Bug 114391 - Bugzilla should show bubbles from webkit-queues.appspot.com
Summary: Bugzilla should show bubbles from webkit-queues.appspot.com
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-10 16:35 PDT by Ryosuke Niwa
Modified: 2013-04-10 16:58 PDT (History)
5 users (show)

See Also:

Attachments
Fixes the bug (4.61 KB, patch)
2013-04-10 16:38 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Fixed per comment (4.60 KB, patch)
2013-04-10 16:52 PDT, Ryosuke Niwa 		benjamin: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-04-10 16:35:36 PDT 
Bugzilla should show bubbles from webkit-queues.appspot.com
Comment 1 Ryosuke Niwa 2013-04-10 16:38:05 PDT 
Created attachment 197416 [details]
Fixes the bug
Comment 2 Benjamin Poulain 2013-04-10 16:49:41 PDT 
Comment on attachment 197416 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=197416&action=review

> Websites/bugs.webkit.org/code-review.js:587
> +      statusBubble.src  = 'https://webkit-commit-queue.appspot.com/status-bubble/' + attachment_id;

? It is the old URL.
Comment 3 Ryosuke Niwa 2013-04-10 16:51:23 PDT 
Comment on attachment 197416 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=197416&action=review

>> Websites/bugs.webkit.org/code-review.js:587
>> +      statusBubble.src  = 'https://webkit-commit-queue.appspot.com/status-bubble/' + attachment_id;
> 
> ? It is the old URL.

Oops fixed.
Comment 4 Ryosuke Niwa 2013-04-10 16:52:44 PDT 
Created attachment 197449 [details]
Fixed per comment
Comment 5 Ryosuke Niwa 2013-04-10 16:58:59 PDT 
Committed r148153: <http://trac.webkit.org/changeset/148153>