Bug 114389 - Inspector highlights are offset when the WKView has a header
Summary: Inspector highlights are offset when the WKView has a header
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Beth Dakin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-04-10 16:01 PDT by Beth Dakin
Modified: 2013-04-10 16:24 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.18 KB, patch)
2013-04-10 16:07 PDT, Beth Dakin
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2013-04-10 16:01:54 PDT
Inspector highlights don't match up when the WKView has a header or footer.

<rdar://problem/13522434>
Comment 1 Beth Dakin 2013-04-10 16:07:35 PDT
Created attachment 197413 [details]
Patch
Comment 2 Sam Weinig 2013-04-10 16:19:17 PDT
Comment on attachment 197413 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=197413&action=review

> Source/WebCore/platform/ScrollView.cpp:721
> +    IntPoint viewPoint = contentsPoint + IntPoint(0, headerHeight()) - scrollOffset();

This should be an IntSize.
Comment 3 Beth Dakin 2013-04-10 16:24:47 PDT
Thanks, Sam! http://trac.webkit.org/changeset/148149