Bug 114367 – --minimal build fails with error: Source/WebKit2/Platform/CoreIPC/ArgumentCoder.h:44:36: error: ‘decode’ is not a member of ‘WebCore::TextCheckingResult’

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Vlad Vasilyeu]

./Tools/Scripts/build-webkit --efl --cmakeargs="-DSHARED_CORE=ON" --minimal fails with this error:

 Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/WebProcess/efl/WebProcessMainEfl.cpp.o
In file included from /home/vlad/work/Webkit/WebKit/Source/WebKit2/Platform/CoreIPC/ArgumentDecoder.h:29:0,
                 from /home/vlad/work/Webkit/WebKit/Source/WebKit2/Platform/CoreIPC/Arguments.h:29,
                 from /home/vlad/work/Webkit/WebKit/Source/WebKit2/Platform/CoreIPC/Connection.h:31,
                 from /home/vlad/work/Webkit/WebKit/Source/WebKit2/Platform/CoreIPC/MessageSender.h:30,
                 from /home/vlad/work/Webkit/WebKit/Source/WebKit2/WebProcess/WebPage/WebPage.h:47,
                 from /home/vlad/work/Webkit/WebKit/Source/WebKit2/WebProcess/WebCoreSupport/efl/WebEditorClientEfl.cpp:32
:
/home/vlad/work/Webkit/WebKit/Source/WebKit2/Platform/CoreIPC/ArgumentCoder.h: In static member function ‘static bool Core
IPC::ArgumentCoder<T>::decode(CoreIPC::ArgumentDecoder&, T&) [with T = WebCore::TextCheckingResult]’:
/home/vlad/work/Webkit/WebKit/Source/WebKit2/Platform/CoreIPC/ArgumentDecoder.h:90:49:   instantiated from ‘bool CoreIPC::
ArgumentDecoder::decode(T&) [with T = WebCore::TextCheckingResult]’
/home/vlad/work/Webkit/WebKit/Source/WebKit2/Platform/CoreIPC/ArgumentCoders.h:115:13:   instantiated from ‘static bool Co
reIPC::VectorArgumentCoder<false, T>::decode(CoreIPC::ArgumentDecoder&, WTF::Vector<CharacterType>&) [with T = WebCore::TextCheckingResult]’
/home/vlad/work/Webkit/WebKit/Source/WebKit2/Platform/CoreIPC/ArgumentDecoder.h:90:49:   instantiated from ‘bool CoreIPC::ArgumentDecoder::decode(T&) [with T = WTF::Vector<WebCore::TextCheckingResult>]’
/home/vlad/work/Webkit/WebKit/Source/WebKit2/Platform/CoreIPC/Arguments.h:67:47:   instantiated from ‘static bool CoreIPC::Arguments1<T1>::decode(CoreIPC::ArgumentDecoder&, CoreIPC::Arguments1<T1>&) [with T1 = WTF::Vector<WebCore::TextCheckingResult>&, CoreIPC::Arguments1<T1> = CoreIPC::Arguments1<WTF::Vector<WebCore::TextCheckingResult>&>]’
/home/vlad/work/Webkit/WebKit/Source/WebKit2/Platform/CoreIPC/ArgumentCoder.h:44:36:   instantiated from ‘static bool CoreIPC::ArgumentCoder<T>::decode(CoreIPC::ArgumentDecoder&, T&) [with T = CoreIPC::Arguments1<WTF::Vector<WebCore::TextCheckingResult>&>]’
ngResult>&>]’
/home/vlad/work/Webkit/WebKit/Source/WebKit2/Platform/CoreIPC/ArgumentDecoder.h:90:49:   instantiated from ‘bool CoreIPC::ArgumentDecoder::decode(T&) [with T = CoreIPC::Arguments1<WTF::Vector<WebCore::TextCheckingResult>&>]’
/home/vlad/work/Webkit/WebKit/Source/WebKit2/Platform/CoreIPC/Connection.h:381:70:   instantiated from ‘bool CoreIPC::Connection::sendSync(const T&, const typename T::Reply&, uint64_t, double, unsigned int) [with T = Messages::WebPageProxy::CheckTextOfParagraph, typename T::Reply = CoreIPC::Arguments1<WTF::Vector<WebCore::TextCheckingResult>&>, uint64_t = long long unsigned int]’
/home/vlad/work/Webkit/WebKit/Source/WebKit2/Platform/CoreIPC/MessageSender.h:69:75:   instantiated from ‘bool CoreIPC::MessageSender<T>::sendSync(const U&, const typename U::Reply&, uint64_t, double) [with U = Messages::WebPageProxy::CheckTextOfParagraph, T = WebKit::WebPage, typename U::Reply = CoreIPC::Arguments1<WTF::Vector<WebCore::TextCheckingResult>&>, uint64_t = long long unsigned int]’
/home/vlad/work/Webkit/WebKit/Source/WebKit2/Platform/CoreIPC/MessageSender.h:61:88:   instantiated from ‘bool CoreIPC::MessageSender<T>::sendSync(const U&, const typename U::Reply&, double) [with U = Messages::WebPageProxy::CheckTextOfParagraph, T = WebKit::WebPage, typename U::Reply = CoreIPC::Arguments1<WTF::Vector<WebCore::TextCheckingResult>&>]’
/home/vlad/work/Webkit/WebKit/Source/WebKit2/WebProcess/WebCoreSupport/efl/WebEditorClientEfl.cpp:66:165:   instantiated from here
/home/vlad/work/Webkit/WebKit/Source/WebKit2/Platform/CoreIPC/ArgumentCoder.h:44:36: error: ‘decode’ is not a member of ‘WebCore::TextCheckingResult’
/home/vlad/work/Webkit/WebKit/Source/WebKit2/Platform/CoreIPC/ArgumentCoder.h:45:5: error: control reaches end of non-void function [-Werror=return-type]
cc1plus: all warnings being treated as errors
make[2]: *** [Source/WebKit2/CMakeFiles/ewebkit2.dir/WebProcess/WebCoreSupport/efl/WebEditorClientEfl.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [Source/WebKit2/CMakeFiles/ewebkit2.dir/all] Error 2
make: *** [all] Error 2

[Vlad Vasilyeu]

Created attachment 197632 [details]
Patch

[WebKit Commit Bot]

Attachment 197632 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/WebCoreSupport/efl/WebEditorClientEfl.cpp']" exit_code: 1
Source/WebKit2/WebProcess/WebCoreSupport/efl/WebEditorClientEfl.cpp:39:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Vlad Vasilyeu]

Created attachment 197636 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 197636 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=197636&action=review

> Source/WebCore/ChangeLog:10
> +        * editing/chromium: Copied from Source/WebCore/editing/chromium.

This patch doesn't include this modification. Remove this changelog.

> Source/WebKit2/ChangeLog:3
> +        --minimal build fails with error: Source/WebKit2/Platform/CoreIPC/ArgumentCoder.h:44:36: error: âdecodeâ is not a member of âWebCore::TextCheckingResultâ

No clear bug title. Please use summarized bug tile which can represent your problem or patch.

[Vlad Vasilyeu]

Created attachment 198120 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 198120 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=198120&action=review

FYI, there is a instruction how to contribute a patch to WebKit. http://www.webkit.org/coding/contributing.html

> Source/WebCore/ChangeLog:3
> +        [EFL] Fixed build failure with option --minimal 

This patch doesn't touch any files in WebCore. So, you should not update ChangeLog of WebCore. Do not include this in this patch.

> Source/WebKit2/ChangeLog:7
> +

Please add a description to explain why this patch is added or what is added.

[Gyuyoung Kim]

Comment on attachment 198120 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=198120&action=review

> Source/WebKit2/ChangeLog:3
> +        [EFL] Fixed build failure with option --minimal 

One more thing, you have to sync with Bugzilla bug title as well.

[Vlad Vasilyeu]

Created attachment 198751 [details]
Patch

[Benjamin Poulain]

Comment on attachment 198751 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=198751&action=review

> Source/WebKit2/ChangeLog:2
> [phone]  Vlad Vasilyeu  <[e-mail]>
> +

Missing title and bug number.

> Source/WebKit2/ChangeLog:5
> +        Source/WebKit2/Platform/CoreIPC/ArgumentCoder.h:44:36: error: âdecodeâ
> +        is not a member of âWebCore::TextCheckingResultâ

Looks like some encoding issues here. Is it the review tool or the ChangeLog?

[Vlad Vasilyeu]

Created attachment 198829 [details]
Patch

[Ed Bartosh]

*** Bug 113792 has been marked as a duplicate of this bug. ***

[Grzegorz Czajkowski]

Comment on attachment 198829 [details]
Patch

Thanks.

[WebKit Commit Bot]

Comment on attachment 198829 [details]
Patch

Clearing flags on attachment: 198829

Committed r149022: <http://trac.webkit.org/changeset/149022>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Grzegorz Czajkowski]

Additionally, we could consider to disable spell checking feature for minimal build.
EFL and GTK+ use ENABLE_SPELLCHECK macro to link against Enchant library and as a result the most spell checking code is guarded by it.

Do you go along with that? I guess it should be an separate bug.

[Vlad Vasilyeu]

This problem depends at least on bug #114299. If you can please review this bug.

[Ed Bartosh]

Gregorz, here is the patch to disable spellcheck and many other options for minimal build: https://bug-113660-attachments.webkit.org/attachment.cgi?id=197144

I'm working on fixing minimal build. More than 10 patches have been already landed, but there are at least 4 still waiting for review. And new breakages are continuously coming to the codebase. Unfortunately patches have been reviewed quite slow. For example 113660 depends on https://bugs.webkit.org/show_bug.cgi?id=114299 but it stays untouched by reviewers for more than 10 days already.

If you can help review 114299 and then 113600 that would be great!

[Grzegorz Czajkowski]

(In reply to comment #17)
> Gregorz, here is the patch to disable spellcheck and many other options for minimal build: https://bug-113660-attachments.webkit.org/attachment.cgi?id=197144

That's great! Adding Laszlo due to build system changes.

> I'm working on fixing minimal build. More than 10 patches have been already landed, but there are at least 4 still waiting for review. And new breakages are continuously coming to the codebase.

If the minial build is essential maybe it's worth adding a separate EWS for it. Otherwise, we will have problems with minimal build as the developers probably don't pay attention on it.

Unfortunately patches have been reviewed quite slow. For example 113660 depends on https://bugs.webkit.org/show_bug.cgi?id=114299 but it stays untouched by reviewers for more than 10 days already.
> 
> If you can help review 114299 and then 113600 that would be great!

It's better to ask Laszko/Raphael for build related changes.