Refactor Editor::markAndReplaceFor before fixing autocorrection bugs
Created attachment 197227 [details]
Created attachment 197230 [details]
Comment on attachment 197230 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=197230&action=review
Looks ok to me. just few nits in the change log.
> + This patch refactors Editor::markAndReplaceFor so that we can start fixing bugs in a sane staet.
> + In particular, shouldMarkSpelling used to be set false when shouldShowCorrectionPanel was true
> + since shouldMarkSpelling was only referred once after the assignment.
> + bool existingMarkersPermitReplacement = m_alternativeTextController->processMarkersOnTextToBeReplacedByResult(&results[i], rangeToReplace.get(), replacedString);
Can this be const as well?
Thanks for the review! Will land after fixing these nits.
Committed r148124: <http://trac.webkit.org/changeset/148124>