Bug 114336 - Removed bitrotted TimeoutChecker code
Summary: Removed bitrotted TimeoutChecker code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-09 23:18 PDT by Geoffrey Garen
Modified: 2013-04-10 11:50 PDT (History)
10 users (show)

See Also:

Attachments
Patch (57.12 KB, patch)
2013-04-09 23:21 PDT, Geoffrey Garen 		no flags Details | Formatted Diff | Diff
Patch (57.57 KB, patch)
2013-04-10 08:49 PDT, Geoffrey Garen 		ap: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2013-04-09 23:18:04 PDT 
Removed bitrotted TimeoutChecker code
Comment 1 Geoffrey Garen 2013-04-09 23:21:35 PDT 
Created attachment 197214 [details]
Patch
Comment 2 EFL EWS Bot 2013-04-10 02:32:05 PDT 
Comment on attachment 197214 [details]
Patch

Attachment 197214 [details] did not pass efl-ews (efl):
Output: http://webkit-commit-queue.appspot.com/results/17710082
Comment 3 EFL EWS Bot 2013-04-10 03:58:18 PDT 
Comment on attachment 197214 [details]
Patch

Attachment 197214 [details] did not pass efl-ews (efl):
Output: http://webkit-commit-queue.appspot.com/results/17604070
Comment 4 Geoffrey Garen 2013-04-10 08:49:33 PDT 
Created attachment 197273 [details]
Patch
Comment 5 Alexey Proskuryakov 2013-04-10 09:47:15 PDT 
Comment on attachment 197273 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=197273&action=review

Oh, this smell of bitrot in the morning...

> Source/JavaScriptCore/ChangeLog:31
> +        * dfg/DFGGPRInfo.h:
> +        (GPRInfo):
> +        * jit/JIT.cpp:
> +        (JSC):
> +        * jit/JIT.h:
> +        (JIT):
> +        * jit/JITStubs.cpp:
> +        (JSC):

This is so unhelpful. Personally, I think that even file lists are unnecessary in ChangeLogs for patches like this, but listing namespaces is just wrong.
Comment 6 Geoffrey Garen 2013-04-10 11:50:14 PDT 
Committed r148119: <http://trac.webkit.org/changeset/148119>