Bug 114334 - WKPageCopySessionState needs to provide more context to the filter callback
Summary: WKPageCopySessionState needs to provide more context to the filter callback
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Rowe (bdash)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-04-09 23:00 PDT by Mark Rowe (bdash)
Modified: 2013-04-10 11:13 PDT (History)
1 user (show)

See Also:

Attachments
Patch v1 (5.14 KB, patch)
2013-04-09 23:01 PDT, Mark Rowe (bdash) 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Rowe (bdash) 2013-04-09 23:00:06 PDT 
WKPageCopySessionState passes the filter callback the original, pre-redirect URL of each entry in the back / forward list.  The filter callback should be passed more context, at least the actual URL of the back / forward list entries.

<rdar://problem/13617104>
Comment 1 Mark Rowe (bdash) 2013-04-09 23:01:06 PDT 
Created attachment 197212 [details]
Patch v1
Comment 2 WebKit Commit Bot 2013-04-10 10:53:35 PDT 
Attachment 197212 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/UIProcess/API/C/WKPage.cpp', u'Source/WebKit2/UIProcess/API/C/WKPage.h', u'Source/WebKit2/UIProcess/cf/WebBackForwardListCF.cpp']" exit_code: 1
Source/WebKit2/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Mark Rowe (bdash) 2013-04-10 11:13:31 PDT 
Landed in r148112.