Bug 114326 – [webkitpy] Remove chromium ports.

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Glenn Adams]

Remove chromium ports from webkitpy.layout_tests.port. As a side effect, also:

* remove chromium builders from webkitpy.layout_tests.port.builders
* remove chromium builders from rebaseline
* rewrite chromium dependent tests in rebaseline_unittest
* remove chromium platform from garden-o-matic
* select apple platform as default platform in garden-o-matic
* remove chromium port dependencies from a few other tests (run_webkit_tests_integrationtest, factory_unittest, style.checkers.test_expectations_unittest)

[Glenn Adams]

Created attachment 197193 [details]
Patch

[Dirk Pranke]

Comment on attachment 197193 [details]
Patch

This looks approximately right. *Sniff*.

[Glenn Adams]

(In reply to comment #2)
> (From update of attachment 197193 [details])
> This looks approximately right. *Sniff*.

I know ... i'm not happy to see cr go either. I wish it had been otherwise, but hey, let's make this new thing work both ways!

[WebKit Commit Bot]

Comment on attachment 197193 [details]
Patch

Clearing flags on attachment: 197193

Committed r148075: <http://trac.webkit.org/changeset/148075>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Csaba Osztrogonác]

(In reply to comment #4)
> (From update of attachment 197193 [details])
> Clearing flags on attachment: 197193
> 
> Committed r148075: <http://trac.webkit.org/changeset/148075>

It broke 3 webkitpy unittest:

 Traceback (most recent call last):
    File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py", line 968, in test_exception_handling
      self.assertEqual(res, run_webkit_tests.INTERRUPTED_EXIT_STATUS)
  AssertionError: 254 != 130
  
[701/1469] webkitpy.common.system.executive_unittest.ExecutiveTest.test_run_command_with_unicode (+19)                                                                                                      [762/1469] webkitpy.layout_tests.run_webkit_tests_integrationtest.RunTest.test_gc_between_tests passed                                                                                                      [774/1469] webkitpy.layout_tests.port.server_process_unittest.TestServerProcess.test_basic erred:
  Traceback (most recent call last):
    File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/layout_tests/port/server_process_unittest.py", line 102, in test_basic
      port = factory.get()
    File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/layout_tests/port/factory.py", line 118, in get
      raise NotImplementedError('unsupported platform: "%s"' % port_name)
  NotImplementedError: unsupported platform: "chromium-linux"
  
[775/1469] webkitpy.layout_tests.run_webkit_tests_integrationtest.RunTest.test_build_check failed:
  Traceback (most recent call last):
    File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py", line 828, in test_build_check
      self.assertEqual(run_webkit_tests.main(['--platform', port_name, 'fast/harness/results.html'], out, err), -1)
  AssertionError: 254 != -1
  
[818/1469] webkitpy.common.system.executive_unittest.ExecutiveTest.test_run_command_with_unicode (+14)

[Glenn Adams]

(In reply to comment #6)
> (In reply to comment #4)
> > (From update of attachment 197193 [details] [details])
> > Clearing flags on attachment: 197193
> > 
> > Committed r148075: <http://trac.webkit.org/changeset/148075>
> 
> It broke 3 webkitpy unittest:

Thanks, I thought I'd fixed the test_build_check() with a follow up patch at http://trac.webkit.org/changeset/148077, and, in fact, I'm not seeing any of these fails on my platform (Mac OSX 10.8.3).  So I'll investigate and post a follow-up patch later this morning. I might ask you to verify/review if that's ok.

[Glenn Adams]

(In reply to comment #7)
> (In reply to comment #6)
> > (In reply to comment #4)
> > > (From update of attachment 197193 [details] [details] [details])
> > > Clearing flags on attachment: 197193
> > > 
> > > Committed r148075: <http://trac.webkit.org/changeset/148075>
> > 
> > It broke 3 webkitpy unittest:
> 
> Thanks, I thought I'd fixed the test_build_check() with a follow up patch at http://trac.webkit.org/changeset/148077, and, in fact, I'm not seeing any of these fails on my platform (Mac OSX 10.8.3).  So I'll investigate and post a follow-up patch later this morning. I might ask you to verify/review if that's ok.

Patch posted at https://bugs.webkit.org/show_bug.cgi?id=114368.