Bug 114323 - TileController doesn't remove tiles when the view is resized, leading to stale content
Summary: TileController doesn't remove tiles when the view is resized, leading to stal...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-04-09 17:12 PDT by Tim Horton
Modified: 2013-04-10 09:31 PDT (History)
3 users (show)

See Also:

Attachments
patch (3.83 KB, patch)
2013-04-09 18:02 PDT, Tim Horton 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2013-04-09 17:12:53 PDT 
You can see this when browsing around Amazon with Aggressive Tile Retention on:

1. Go to http://www.amazon.com/Best-Sellers-Video-Games-PlayStation-Hardware/zgbs/videogames/14210751/
2. Scroll to the bottom.
3. Click on the next page of results.
4. Scroll to the bottom.
5. Move the mouse around. You'll probably see stale content start repainting.

<rdar://problem/13520671>
Comment 1 Tim Horton 2013-04-09 18:02:14 PDT 
Created attachment 197194 [details]
patch
Comment 2 Simon Fraser (smfr) 2013-04-09 18:09:18 PDT 
Comment on attachment 197194 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=197194&action=review

> Source/WebCore/platform/graphics/ca/mac/TileController.mm:736
> +            if (it->key.y() < topLeftForBounds.y()
> +                || it->key.y() > bottomRightForBounds.y()
> +                || it->key.x() < topLeftForBounds.x()
> +                || it->key.x() > bottomRightForBounds.x())

Would be cleaner if you copied it->key into a TileIndex variable.
Comment 3 Tim Horton 2013-04-10 09:31:41 PDT 
http://trac.webkit.org/changeset/148102