InspectorConsoleAgent::didFinishXHRLoading creates a ConsoleMessage with a line number, but it should also include a column number. It looks like ultimately the line number comes from JSXMLHttpRequest::send, it should also be possible to get the column number at the time. The column number would be needed by the Web Inspector to jump to the proper place in source code to show where the XHR originated from.
<rdar://problem/13614521>
Created attachment 216271 [details] Patch
Comment on attachment 216271 [details] Patch Attachment 216271 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/22718143
Comment on attachment 216271 [details] Patch Attachment 216271 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/22768126
Comment on attachment 216271 [details] Patch Attachment 216271 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/22698160
Comment on attachment 216271 [details] Patch Attachment 216271 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/22368135
Comment on attachment 216271 [details] Patch Attachment 216271 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/22728154
Created attachment 216274 [details] Patch
Comment on attachment 216274 [details] Patch Rejecting attachment 216274 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 216274, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/22588219
Oh, it wasn't the reviewer OOPS. It was the tests OOPS.
Comment on attachment 216274 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=216274&action=review > Source/WebCore/xml/XMLHttpRequest.h:141 > void setLastSendLineNumber(unsigned lineNumber) { m_lastSendLineNumber = lineNumber; } > + void setLastSendColumnNumber(unsigned columnNumber) { m_lastSendColumnNumber = columnNumber; } This could probably be: setLastSendLineAndColumnNumber(…). Making it two separate setters leaves the possibility that someone might do one and forgot to do the other. However, that is just a nit, the patch looks good!
Created attachment 216364 [details] Patch
Comment on attachment 216364 [details] Patch Clearing flags on attachment: 216364 Committed r158935: <http://trac.webkit.org/changeset/158935>
All reviewed patches have been landed. Closing bug.