Bug 114314 – FindBanner matches are offset when the WKView has a header or footer

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Beth Dakin]

FindBanner matches don't line up correctly when a WKView has a header or footer. 

<rdar://problem/13522434>

[Beth Dakin]

Created attachment 197187 [details]
Patch

[Beth Dakin]

Created attachment 197392 [details]
Patch with new names

[Tim Horton]

Comment on attachment 197392 [details]
Patch with new names

View in context: https://bugs.webkit.org/attachment.cgi?id=197392&action=review

> Source/WebCore/platform/ScrollView.cpp:338
> +IntSize ScrollView::scrollOffsetRealtiveToDocument() const

Relative?

[Tim Horton]

Comment on attachment 197392 [details]
Patch with new names

View in context: https://bugs.webkit.org/attachment.cgi?id=197392&action=review

> Source/WebCore/rendering/RenderLayer.cpp:2384
> +LayoutRect RenderLayer::getRectToExpose(const LayoutRect &visibleRect, LayoutRect &visibleRectRealtiveToDocument, const LayoutRect &exposeRect, const ScrollAlignment& alignX, const ScrollAlignment& alignY)

Relative again.

> Source/WebCore/rendering/RenderLayer.cpp:2424
> +    LayoutUnit intersectHeight = intersection(visibleRectRealtiveToDocument, exposeRectY).height();

And here.

[Simon Fraser (smfr)]

Comment on attachment 197392 [details]
Patch with new names

View in context: https://bugs.webkit.org/attachment.cgi?id=197392&action=review

> Source/WebCore/ChangeLog:17
> +        New function subtracts out the headerHeight() to treat the top of the document at 
> +        (0,0).

Awkward line breaking.

> Source/WebCore/WebCore.exp.in:1227
> +__ZNK7WebCore10ScrollView30scrollOffsetRealtiveToDocumentEv

Typo.

[Beth Dakin]

Created attachment 197395 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 197395 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=197395&action=review

> Source/WebCore/ChangeLog:22
> +        Use scrollOffsetRealtiveToDocument() where we were previously making this 

Still misspelledt here.

> Source/WebCore/platform/ScrollView.cpp:753
> +    IntSize offsetRelativeToTotalContents = scrollOffset() + IntSize(0, headerHeight());

offsetIncludingHeader?

> Source/WebCore/rendering/RenderLayer.h:404
> +    LayoutRect getRectToExpose(const LayoutRect& visibleRect, LayoutRect& visibleRectRelativeToDocument, const LayoutRect& exposeRect, const ScrollAlignment& alignX, const ScrollAlignment& alignY);

visibleRectRelativeToDocument should be a const LayoutRect&, no?

[Beth Dakin]

Thanks Simon!

http://trac.webkit.org/changeset/148137