Bug 114312 - JSCustomXPathNSResolver::lookupNamespaceURI Console Message should render with a column number
Summary: JSCustomXPathNSResolver::lookupNamespaceURI Console Message should render wit...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: John Wilander
URL:
Keywords: EasyFix, GoodFirstBug, InRadar
Depends on:
Blocks:
 
Reported: 2013-04-09 15:55 PDT by Joseph Pecoraro
Modified: 2016-01-04 16:22 PST (History)
8 users (show)

See Also:

Attachments
test case (867 bytes, application/xhtml+xml)
2015-11-20 13:18 PST, BJ Burg 		no flags Details
[PATCH] Proposed Fix (1.59 KB, patch)
2016-01-04 12:52 PST, Joseph Pecoraro 		bfulgham: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
[PATCH] For Landing (1.62 KB, patch)
2016-01-04 15:23 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2013-04-09 15:55:40 PDT 
JSCustomXPathNSResolver::lookupNamespaceURI (Source/WebCore/bindings/js/JSCustomXPathNSResolver.cpp) logs a ConsoleMessage error. it should include a line, column, and sourceURL so an error in the inspector can jump to the source code that made the call.
Comment 1 Radar WebKit Bug Importer 2013-04-09 15:55:57 PDT 
<rdar://problem/13614284>
Comment 2 Diego Pino 2014-09-19 03:46:42 PDT 
I reproduced the bug by opening LayoutTests/fast/xpath/nsresolver-bad-object.xhtml in MiniBrowser and opening the WebInspector console. There's a link to the source file, column number, and line number, although console->addMessage is logged without these values.

Maybe this information is filled up somewhere by the inspector in case it was not provided? Or maybe I'm not reproducing this bug correctly :)
Comment 3 Alexey Proskuryakov 2015-02-23 12:20:48 PST 
This appears to work in shipping Safari now.
Comment 4 BJ Burg 2015-11-20 13:18:54 PST 
Created attachment 265983 [details]
test case
Comment 5 Brent Fulgham 2015-12-22 14:53:13 PST 
This now works properly.
Comment 6 Joseph Pecoraro 2016-01-04 12:30:56 PST 
This bug is probably fixed, but there is still a FIXME to fix it in Source/WebCore/bindings/js/JSCustomXPathNSResolver.cpp. I'll test and remove if it appears fixed.
Comment 7 Joseph Pecoraro 2016-01-04 12:52:25 PST 
Reopening so we can remove the FIXME.
Comment 8 Joseph Pecoraro 2016-01-04 12:52:57 PST 
Created attachment 268223 [details]
[PATCH] Proposed Fix

Yep, works even when the JS code is minified. Remove the FIXME.
Comment 9 Brent Fulgham 2016-01-04 12:55:57 PST 
Comment on attachment 268223 [details]
[PATCH] Proposed Fix

r=me. Do it!
Comment 10 WebKit Commit Bot 2016-01-04 12:57:04 PST 
Comment on attachment 268223 [details]
[PATCH] Proposed Fix

Rejecting attachment 268223 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 268223, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.webkit.org/results/649861
Comment 11 Joseph Pecoraro 2016-01-04 15:23:30 PST 
Created attachment 268240 [details]
[PATCH] For Landing
Comment 12 WebKit Commit Bot 2016-01-04 16:22:52 PST 
Comment on attachment 268240 [details]
[PATCH] For Landing

Clearing flags on attachment: 268240

Committed r194564: <http://trac.webkit.org/changeset/194564>
Comment 13 WebKit Commit Bot 2016-01-04 16:22:57 PST 
All reviewed patches have been landed.  Closing bug.