RESOLVED INVALID 114308
[EFL] build fails with error: missing binary operator before token "(" 
https://bugs.webkit.org/show_bug.cgi?id=114308
Summary [EFL] build fails with error: missing binary operator before token "("
Ed Bartosh
Reported 2013-04-09 14:15:30 PDT
With applied this patch https://bugs.webkit.org/attachment.cgi?id=197170 build fails this way: In file included from /home/ed/git/wk/WebKit/Source/WebKit2/UIProcess/API/efl/EWebKit2.h:36:0, from /home/ed/git/wk/WebKit/Tools/MiniBrowser/efl/main.c:20: /home/ed/git/wk/WebKit/Source/WebKit2/UIProcess/API/efl/ewk_context_menu.h:34:11: error: missing binary operator before token "(" In file included from /home/ed/git/wk/WebKit/Source/WebKit2/UIProcess/API/efl/ewk_popup_menu_item.h:34:0, from /home/ed/git/wk/WebKit/Source/WebKit2/UIProcess/API/efl/EWebKit2.h:51, from /home/ed/git/wk/WebKit/Tools/MiniBrowser/efl/main.c:20: /home/ed/git/wk/WebKit/Source/WebKit2/UIProcess/API/efl/ewk_view.h:117:11: error: missing binary operator before token "(" In file included from /home/ed/git/wk/WebKit/Source/WebKit2/UIProcess/API/efl/ewk_popup_menu_item.h:34:0, from /home/ed/git/wk/WebKit/Source/WebKit2/UIProcess/API/efl/EWebKit2.h:51, from /home/ed/git/wk/WebKit/Tools/MiniBrowser/efl/main.c:20: /home/ed/git/wk/WebKit/Source/WebKit2/UIProcess/API/efl/ewk_view.h:178:11: error: missing binary operator before token "("
Attachments
Patch (1.64 KB, patch)
2013-04-09 14:24 PDT, Ed Bartosh 		no flags
DetailsFormatted DiffDiff
Patch (1.68 KB, patch)
2013-04-09 14:36 PDT, Ed Bartosh 		gyuyoung.kim: review-
gyuyoung.kim: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ed Bartosh
Comment 1 2013-04-09 14:24:52 PDT
Created attachment 197176 [details] Patch
Ed Bartosh
Comment 2 2013-04-09 14:36:14 PDT
Created attachment 197177 [details] Patch
Gyuyoung Kim
Comment 3 2013-04-10 20:25:54 PDT
Comment on attachment 197177 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=197177&action=review > Tools/ChangeLog:9 > + * MiniBrowser/efl/main.c: Included config.h to be able to use ENABLE macro Where does MiniBrowser use ENABLE macro ? > Tools/MiniBrowser/efl/main.c:20 > +#include "config.h" MiniBrowser is sample program. So, MiniBrowser should not use WebKit function except for public APIs
Ed Bartosh
Comment 4 2013-04-11 13:44:43 PDT
Closing as invalid. After latest changes in #11949 this issue is not reproducible.
Note You need to log in before you can comment on or make changes to this bug.