Bug 114260 - [GTK][AC] Clean up code related with the children management stuff for clutter based AC
Summary: [GTK][AC] Clean up code related with the children management stuff for clutte...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 105699
  Show dependency treegraph
 
Reported: 2013-04-09 03:02 PDT by ChangSeok Oh
Modified: 2013-04-29 07:35 PDT (History)
2 users (show)

See Also:


Attachments
Patch (17.63 KB, patch)
2013-04-19 11:49 PDT, ChangSeok Oh
no flags Details | Formatted Diff | Diff
Patch (13.59 KB, patch)
2013-04-25 01:07 PDT, ChangSeok Oh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description ChangSeok Oh 2013-04-09 03:02:08 PDT
We have lots of unused functions and variable stuff for clutter based AC.
I want to clean them up here.
Comment 1 ChangSeok Oh 2013-04-19 11:49:02 PDT
Created attachment 198904 [details]
Patch
Comment 2 Gustavo Noronha (kov) 2013-04-24 07:59:41 PDT
Comment on attachment 198904 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=198904&action=review

> Source/WebCore/platform/graphics/clutter/GraphicsLayerClutter.cpp:270
> -        graphicsLayerActorRemoveAll(GRAPHICS_LAYER_ACTOR(actor.get()));
> +        clutter_actor_remove_all_children(actor.get());

I would prefer if you split this in two patches, one dealing with cleaning up the children management stuff and one cleaning up scrolling/translation.
Comment 3 ChangSeok Oh 2013-04-25 01:07:11 PDT
Created attachment 199628 [details]
Patch
Comment 4 ChangSeok Oh 2013-04-25 01:12:11 PDT
(In reply to comment #2)
> (From update of attachment 198904 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=198904&action=review
> 
> > Source/WebCore/platform/graphics/clutter/GraphicsLayerClutter.cpp:270
> > -        graphicsLayerActorRemoveAll(GRAPHICS_LAYER_ACTOR(actor.get()));
> > +        clutter_actor_remove_all_children(actor.get());
> 
> I would prefer if you split this in two patches, one dealing with cleaning up the children management stuff and one cleaning up scrolling/translation.

Yup. I opened a new bug to deal with cleaning up scroll/translation here.
https://bugs.webkit.org/show_bug.cgi?id=115160
Comment 5 WebKit Commit Bot 2013-04-29 07:35:34 PDT
Comment on attachment 199628 [details]
Patch

Clearing flags on attachment: 199628

Committed r149281: <http://trac.webkit.org/changeset/149281>
Comment 6 WebKit Commit Bot 2013-04-29 07:35:36 PDT
All reviewed patches have been landed.  Closing bug.