Bug 114260 – [GTK][AC] Clean up code related with the children management stuff for clutter based AC

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[ChangSeok Oh]

We have lots of unused functions and variable stuff for clutter based AC.
I want to clean them up here.

[ChangSeok Oh]

Created attachment 198904 [details]
Patch

[Gustavo Noronha (kov)]

Comment on attachment 198904 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=198904&action=review

> Source/WebCore/platform/graphics/clutter/GraphicsLayerClutter.cpp:270
> -        graphicsLayerActorRemoveAll(GRAPHICS_LAYER_ACTOR(actor.get()));
> +        clutter_actor_remove_all_children(actor.get());

I would prefer if you split this in two patches, one dealing with cleaning up the children management stuff and one cleaning up scrolling/translation.

[ChangSeok Oh]

Created attachment 199628 [details]
Patch

[ChangSeok Oh]

(In reply to comment #2)
> (From update of attachment 198904 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=198904&action=review
> 
> > Source/WebCore/platform/graphics/clutter/GraphicsLayerClutter.cpp:270
> > -        graphicsLayerActorRemoveAll(GRAPHICS_LAYER_ACTOR(actor.get()));
> > +        clutter_actor_remove_all_children(actor.get());
> 
> I would prefer if you split this in two patches, one dealing with cleaning up the children management stuff and one cleaning up scrolling/translation.

Yup. I opened a new bug to deal with cleaning up scroll/translation here.
https://bugs.webkit.org/show_bug.cgi?id=115160

[WebKit Commit Bot]

Comment on attachment 199628 [details]
Patch

Clearing flags on attachment: 199628

Committed r149281: <http://trac.webkit.org/changeset/149281>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.