Bug 114258 - Initialization skipped error on WinCario after r147643
Summary: Initialization skipped error on WinCario after r147643
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Windows 7
: P2 Trivial
Assignee: Gabor Loki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-09 02:43 PDT by Gabor Loki
Modified: 2013-04-09 03:43 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.95 KB, patch)
2013-04-09 02:46 PDT, Gabor Loki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Loki 2013-04-09 02:43:38 PDT
There is compiler error on WinCario after http://trac.webkit.org/changeset/147643

The output (http://build.webkit.org/builders/WinCairo%20Release/builds/25100/steps/compile-webkit/logs/stdio) says:

 platform\win\DragImageCairoWin.cpp(184) : error C2362: initialization of 'surface' is skipped by 'goto exit'


which can be fixed by adding an extra block statement ( http://msdn.microsoft.com/en-us/library/s6s80d9f(v=vs.80).aspx ).
Comment 1 Gabor Loki 2013-04-09 02:46:58 PDT
Created attachment 197014 [details]
Patch
Comment 2 Csaba Osztrogonác 2013-04-09 03:12:27 PDT
Comment on attachment 197014 [details]
Patch

LGTM, r=me.
Comment 3 WebKit Commit Bot 2013-04-09 03:43:08 PDT
Comment on attachment 197014 [details]
Patch

Clearing flags on attachment: 197014

Committed r148003: <http://trac.webkit.org/changeset/148003>
Comment 4 WebKit Commit Bot 2013-04-09 03:43:11 PDT
All reviewed patches have been landed.  Closing bug.