WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
114228
[webkitpy] Remove chromium deprecated port support
https://bugs.webkit.org/show_bug.cgi?id=114228
Summary
[webkitpy] Remove chromium deprecated port support
Glenn Adams
Reported
2013-04-08 18:18:13 PDT
Remove chromium port support.
Attachments
Patch
(8.55 KB, patch)
2013-04-09 10:08 PDT
,
Glenn Adams
no flags
Details
Formatted Diff
Diff
Patch for landing
(8.56 KB, patch)
2013-04-09 11:38 PDT
,
Glenn Adams
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Glenn Adams
Comment 1
2013-04-09 10:08:51 PDT
Created
attachment 197140
[details]
Patch
Ryosuke Niwa
Comment 2
2013-04-09 10:12:57 PDT
Comment on
attachment 197140
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=197140&action=review
> Tools/ChangeLog:3 > + [webkitpy] Remove chromium port support.
You’re just removing the deprecated ports. There are also non-deprecated ports in layout_tests/ports/
Glenn Adams
Comment 3
2013-04-09 11:03:18 PDT
(In reply to
comment #2
)
> (From update of
attachment 197140
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=197140&action=review
> > > Tools/ChangeLog:3 > > + [webkitpy] Remove chromium port support. > > You’re just removing the deprecated ports. There are also non-deprecated ports in layout_tests/ports/
Correct. I wanted to do this one step at a time to partition potential regression and test-webkitpy impact.
Ryosuke Niwa
Comment 4
2013-04-09 11:25:03 PDT
Comment on
attachment 197140
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=197140&action=review
>>> Tools/ChangeLog:3 >>> + [webkitpy] Remove chromium port support. >> >> You’re just removing the deprecated ports. There are also non-deprecated ports in layout_tests/ports/ > > Correct. I wanted to do this one step at a time to partition potential regression and test-webkitpy impact.
Please be sure to update the change log before you land it.
Glenn Adams
Comment 5
2013-04-09 11:38:28 PDT
Created
attachment 197153
[details]
Patch for landing
WebKit Commit Bot
Comment 6
2013-04-09 12:09:06 PDT
Comment on
attachment 197153
[details]
Patch for landing Clearing flags on attachment: 197153 Committed
r148035
: <
http://trac.webkit.org/changeset/148035
>
WebKit Commit Bot
Comment 7
2013-04-09 12:09:08 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug