Bug 114228 - [webkitpy] Remove chromium deprecated port support
Summary: [webkitpy] Remove chromium deprecated port support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Glenn Adams
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-08 18:18 PDT by Glenn Adams
Modified: 2013-04-09 12:09 PDT (History)
8 users (show)

See Also:


Attachments
Patch (8.55 KB, patch)
2013-04-09 10:08 PDT, Glenn Adams
no flags Details | Formatted Diff | Diff
Patch for landing (8.56 KB, patch)
2013-04-09 11:38 PDT, Glenn Adams
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Glenn Adams 2013-04-08 18:18:13 PDT
Remove chromium port support.
Comment 1 Glenn Adams 2013-04-09 10:08:51 PDT
Created attachment 197140 [details]
Patch
Comment 2 Ryosuke Niwa 2013-04-09 10:12:57 PDT
Comment on attachment 197140 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=197140&action=review

> Tools/ChangeLog:3
> +        [webkitpy] Remove chromium port support.

You’re just removing the deprecated ports. There are also non-deprecated ports in layout_tests/ports/
Comment 3 Glenn Adams 2013-04-09 11:03:18 PDT
(In reply to comment #2)
> (From update of attachment 197140 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=197140&action=review
> 
> > Tools/ChangeLog:3
> > +        [webkitpy] Remove chromium port support.
> 
> You’re just removing the deprecated ports. There are also non-deprecated ports in layout_tests/ports/

Correct. I wanted to do this one step at a time to partition potential regression and test-webkitpy impact.
Comment 4 Ryosuke Niwa 2013-04-09 11:25:03 PDT
Comment on attachment 197140 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=197140&action=review

>>> Tools/ChangeLog:3
>>> +        [webkitpy] Remove chromium port support.
>> 
>> You’re just removing the deprecated ports. There are also non-deprecated ports in layout_tests/ports/
> 
> Correct. I wanted to do this one step at a time to partition potential regression and test-webkitpy impact.

Please be sure to update the change log before you land it.
Comment 5 Glenn Adams 2013-04-09 11:38:28 PDT
Created attachment 197153 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2013-04-09 12:09:06 PDT
Comment on attachment 197153 [details]
Patch for landing

Clearing flags on attachment: 197153

Committed r148035: <http://trac.webkit.org/changeset/148035>
Comment 7 WebKit Commit Bot 2013-04-09 12:09:08 PDT
All reviewed patches have been landed.  Closing bug.