WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
114226
Don't try to remove a non-existent snapshot
https://bugs.webkit.org/show_bug.cgi?id=114226
Summary
Don't try to remove a non-existent snapshot
Dean Jackson
Reported
2013-04-08 17:18:33 PDT
We should not fire the remove snapshot timer if there was never a snapshot to remove.
Attachments
Patch
(2.46 KB, patch)
2013-04-08 17:21 PDT
,
Dean Jackson
darin
: review+
webkit-ews
: commit-queue-
Details
Formatted Diff
Diff
Build test (with review modifications)
(2.61 KB, patch)
2013-04-08 19:34 PDT
,
Dean Jackson
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2013-04-08 17:18:57 PDT
<
rdar://problem/13604480
>
Dean Jackson
Comment 2
2013-04-08 17:21:45 PDT
Created
attachment 196975
[details]
Patch
Early Warning System Bot
Comment 3
2013-04-08 17:44:14 PDT
Comment on
attachment 196975
[details]
Patch
Attachment 196975
[details]
did not pass qt-ews (qt): Output:
http://webkit-commit-queue.appspot.com/results/17672003
Darin Adler
Comment 4
2013-04-08 17:45:33 PDT
Comment on
attachment 196975
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=196975&action=review
> Source/WebCore/html/HTMLPlugInImageElement.cpp:96 > + DisplayState previousDisplayState = displayState();
This line of code needs to be inside the same #if as the code below; #if PLATFORM(MAC), although I wish that was not the way we guarded this feature! Please fix that before landing.
Early Warning System Bot
Comment 5
2013-04-08 17:55:57 PDT
Comment on
attachment 196975
[details]
Patch
Attachment 196975
[details]
did not pass qt-wk2-ews (qt): Output:
http://webkit-commit-queue.appspot.com/results/17638017
EFL EWS Bot
Comment 6
2013-04-08 18:19:09 PDT
Comment on
attachment 196975
[details]
Patch
Attachment 196975
[details]
did not pass efl-ews (efl): Output:
http://webkit-commit-queue.appspot.com/results/17641012
Dean Jackson
Comment 7
2013-04-08 19:27:17 PDT
Comment on
attachment 196975
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=196975&action=review
>> Source/WebCore/html/HTMLPlugInImageElement.cpp:96 >> + DisplayState previousDisplayState = displayState(); > > This line of code needs to be inside the same #if as the code below; #if PLATFORM(MAC), although I wish that was not the way we guarded this feature! Please fix that before landing.
It's worse. I can't just move it because we've already updated the state by then. I'll need to put in another #if :( And yes, this feature guarding is horrible. Since MAC is the only place that is doing the crossfade at the moment, this is an implied connection between WebKit2 and WebCore. I guess it would be better as a Setting.
Dean Jackson
Comment 8
2013-04-08 19:29:57 PDT
Comment on
attachment 196975
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=196975&action=review
>>> Source/WebCore/html/HTMLPlugInImageElement.cpp:96 >>> + DisplayState previousDisplayState = displayState(); >> >> This line of code needs to be inside the same #if as the code below; #if PLATFORM(MAC), although I wish that was not the way we guarded this feature! Please fix that before landing. > > It's worse. I can't just move it because we've already updated the state by then. I'll need to put in another #if :( > > And yes, this feature guarding is horrible. Since MAC is the only place that is doing the crossfade at the moment, this is an implied connection between WebKit2 and WebCore. I guess it would be better as a Setting.
I rewrote the method to but the call to super at the end.
Dean Jackson
Comment 9
2013-04-08 19:34:31 PDT
Created
attachment 196981
[details]
Build test (with review modifications)
Dean Jackson
Comment 10
2013-04-08 19:42:28 PDT
Committed
r147977
: <
http://trac.webkit.org/changeset/147977
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug