Bug 114221 - Remove chromium EWS support, and fix broken test.
Summary: Remove chromium EWS support, and fix broken test.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Glenn Adams
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-08 16:34 PDT by Glenn Adams
Modified: 2013-04-08 17:21 PDT (History)
7 users (show)

See Also:


Attachments
Patch (3.72 KB, patch)
2013-04-08 16:41 PDT, Glenn Adams
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Glenn Adams 2013-04-08 16:34:03 PDT
Remove AbstractChromiumEWS class and subclasses (and related unit tests).

Also fix broken unit test:

webkitpy.tool.commands.earlywarningsystem_unittest.EarlyWarningSystemTest.test_ewses

which had a misspelled class name and a non-conforming test entry point name.
Comment 1 Glenn Adams 2013-04-08 16:41:23 PDT
Created attachment 196969 [details]
Patch
Comment 2 Ryosuke Niwa 2013-04-08 17:19:08 PDT
Comment on attachment 196969 [details]
Patch

Oh oops, sorry wrong patch.
Comment 3 WebKit Commit Bot 2013-04-08 17:21:04 PDT
Comment on attachment 196969 [details]
Patch

Clearing flags on attachment: 196969

Committed r147966: <http://trac.webkit.org/changeset/147966>
Comment 4 WebKit Commit Bot 2013-04-08 17:21:06 PDT
All reviewed patches have been landed.  Closing bug.