Stop #include-ing all of JavaScriptCore in every DOM-related file
Created attachment 196961 [details] Patch
Created attachment 196963 [details] Patch
Comment on attachment 196963 [details] Patch Attachment 196963 [details] did not pass qt-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/17627004
Created attachment 196965 [details] Patch
Comment on attachment 196965 [details] Patch Attachment 196965 [details] did not pass qt-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/17596014
Created attachment 196967 [details] Patch
Committed r147962: <http://trac.webkit.org/changeset/147962>
Comment on attachment 196967 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=196967&action=review > Source/JavaScriptCore/runtime/WeakGCMap.h:30 > -#include "Weak.h" > +#include <heap/Weak.h> > +#include <heap/WeakInlines.h> Why are framework style includes necessary here? They are quite unusual in JSC. I'm interested because this prevents including JSArrayBufferView.h from DumpRenderTree somehow. "Weak.h" is fine, but <heap/Weak.h> is not. This can probably be fixed from DumpRenderTree side, but I'm curious what the policy is. Everywhere else in JSC, it's "Weak.h".
Filed bug 123057 for that.