Bug 114220 - Stop #include-ing all of JavaScriptCore in every DOM-related file
Summary: Stop #include-ing all of JavaScriptCore in every DOM-related file
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-08 15:20 PDT by Geoffrey Garen
Modified: 2013-10-19 00:07 PDT (History)
12 users (show)

See Also:


Attachments
Patch (50.87 KB, patch)
2013-04-08 15:25 PDT, Geoffrey Garen
no flags Details | Formatted Diff | Diff
Patch (51.29 KB, patch)
2013-04-08 15:40 PDT, Geoffrey Garen
no flags Details | Formatted Diff | Diff
Patch (54.11 KB, patch)
2013-04-08 15:59 PDT, Geoffrey Garen
no flags Details | Formatted Diff | Diff
Patch (54.85 KB, patch)
2013-04-08 16:15 PDT, Geoffrey Garen
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2013-04-08 15:20:00 PDT
Stop #include-ing all of JavaScriptCore in every DOM-related file
Comment 1 Geoffrey Garen 2013-04-08 15:25:17 PDT
Created attachment 196961 [details]
Patch
Comment 2 Geoffrey Garen 2013-04-08 15:40:52 PDT
Created attachment 196963 [details]
Patch
Comment 3 Early Warning System Bot 2013-04-08 15:56:34 PDT
Comment on attachment 196963 [details]
Patch

Attachment 196963 [details] did not pass qt-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/17627004
Comment 4 Geoffrey Garen 2013-04-08 15:59:05 PDT
Created attachment 196965 [details]
Patch
Comment 5 Early Warning System Bot 2013-04-08 16:13:58 PDT
Comment on attachment 196965 [details]
Patch

Attachment 196965 [details] did not pass qt-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/17596014
Comment 6 Geoffrey Garen 2013-04-08 16:15:11 PDT
Created attachment 196967 [details]
Patch
Comment 7 Geoffrey Garen 2013-04-08 16:39:26 PDT
Committed r147962: <http://trac.webkit.org/changeset/147962>
Comment 8 Alexey Proskuryakov 2013-10-18 23:13:19 PDT
Comment on attachment 196967 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=196967&action=review

> Source/JavaScriptCore/runtime/WeakGCMap.h:30
> -#include "Weak.h"
> +#include <heap/Weak.h>
> +#include <heap/WeakInlines.h>

Why are framework style includes necessary here? They are quite unusual in JSC.

I'm interested because this prevents including JSArrayBufferView.h from DumpRenderTree somehow. "Weak.h" is fine, but <heap/Weak.h> is not.

This can probably be fixed from DumpRenderTree side, but I'm curious what the policy is. Everywhere else in JSC, it's "Weak.h".
Comment 9 Alexey Proskuryakov 2013-10-19 00:07:53 PDT
Filed bug 123057 for that.