WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
114220
Stop #include-ing all of JavaScriptCore in every DOM-related file
https://bugs.webkit.org/show_bug.cgi?id=114220
Summary
Stop #include-ing all of JavaScriptCore in every DOM-related file
Geoffrey Garen
Reported
2013-04-08 15:20:00 PDT
Stop #include-ing all of JavaScriptCore in every DOM-related file
Attachments
Patch
(50.87 KB, patch)
2013-04-08 15:25 PDT
,
Geoffrey Garen
no flags
Details
Formatted Diff
Diff
Patch
(51.29 KB, patch)
2013-04-08 15:40 PDT
,
Geoffrey Garen
no flags
Details
Formatted Diff
Diff
Patch
(54.11 KB, patch)
2013-04-08 15:59 PDT
,
Geoffrey Garen
no flags
Details
Formatted Diff
Diff
Patch
(54.85 KB, patch)
2013-04-08 16:15 PDT
,
Geoffrey Garen
sam
: review+
Details
Formatted Diff
Diff
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
Geoffrey Garen
Comment 1
2013-04-08 15:25:17 PDT
Created
attachment 196961
[details]
Patch
Geoffrey Garen
Comment 2
2013-04-08 15:40:52 PDT
Created
attachment 196963
[details]
Patch
Early Warning System Bot
Comment 3
2013-04-08 15:56:34 PDT
Comment on
attachment 196963
[details]
Patch
Attachment 196963
[details]
did not pass qt-ews (qt): Output:
http://webkit-commit-queue.appspot.com/results/17627004
Geoffrey Garen
Comment 4
2013-04-08 15:59:05 PDT
Created
attachment 196965
[details]
Patch
Early Warning System Bot
Comment 5
2013-04-08 16:13:58 PDT
Comment on
attachment 196965
[details]
Patch
Attachment 196965
[details]
did not pass qt-ews (qt): Output:
http://webkit-commit-queue.appspot.com/results/17596014
Geoffrey Garen
Comment 6
2013-04-08 16:15:11 PDT
Created
attachment 196967
[details]
Patch
Geoffrey Garen
Comment 7
2013-04-08 16:39:26 PDT
Committed
r147962
: <
http://trac.webkit.org/changeset/147962
>
Alexey Proskuryakov
Comment 8
2013-10-18 23:13:19 PDT
Comment on
attachment 196967
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=196967&action=review
> Source/JavaScriptCore/runtime/WeakGCMap.h:30 > -#include "Weak.h" > +#include <heap/Weak.h> > +#include <heap/WeakInlines.h>
Why are framework style includes necessary here? They are quite unusual in JSC. I'm interested because this prevents including JSArrayBufferView.h from DumpRenderTree somehow. "Weak.h" is fine, but <heap/Weak.h> is not. This can probably be fixed from DumpRenderTree side, but I'm curious what the policy is. Everywhere else in JSC, it's "Weak.h".
Alexey Proskuryakov
Comment 9
2013-10-19 00:07:53 PDT
Filed
bug 123057
for that.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug