Created attachment 196961 [details]
Created attachment 196963 [details]
Comment on attachment 196963 [details]
Attachment 196963 [details] did not pass qt-ews (qt):
Created attachment 196965 [details]
Comment on attachment 196965 [details]
Attachment 196965 [details] did not pass qt-ews (qt):
Created attachment 196967 [details]
Committed r147962: <http://trac.webkit.org/changeset/147962>
Comment on attachment 196967 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=196967&action=review
> -#include "Weak.h"
> +#include <heap/Weak.h>
> +#include <heap/WeakInlines.h>
Why are framework style includes necessary here? They are quite unusual in JSC.
I'm interested because this prevents including JSArrayBufferView.h from DumpRenderTree somehow. "Weak.h" is fine, but <heap/Weak.h> is not.
This can probably be fixed from DumpRenderTree side, but I'm curious what the policy is. Everywhere else in JSC, it's "Weak.h".
Filed bug 123057 for that.