Bug 114179 - [CSS Filters] Add automated regression test for CA filter animation
Summary: [CSS Filters] Add automated regression test for CA filter animation
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 68469 109098
  Show dependency treegraph
 
Reported: 2013-04-08 11:18 PDT by Max Vujovic
Modified: 2014-03-02 09:16 PST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Max Vujovic 2013-04-08 11:18:41 PDT
smfr provided a manual test case in bug 114067, which we should automate and check in. He used the test case to find a regression caused by the patch in bug 109098.
Comment 1 Max Vujovic 2013-04-10 16:40:49 PDT
An API to dump the current accelerated animations on a platform layer could be a good way to test this.

I looked at using the Internals::pauseTransitionAtTimeOnElement API to take a snapshot in the middle of an accelerated animation, but it looks like it fast-forwards the animation to the desired time and then does a style recalculation. I don't think this would catch the kind of regression that occurred in bug 114067, where the start state and end state were fine but the accelerated animation didn't run.

See AnimationControllerPrivate::pauseAnimationAtTime...

    if (compAnim->pauseAnimationAtTime(name, t)) {
        renderer->node()->setNeedsStyleRecalc(SyntheticStyleChange);
        startUpdateStyleIfNeededDispatcher();
        return true;
    }