Bug 114148 - [BlackBerry] WebPage: fix build due to type mismatches
Summary: [BlackBerry] WebPage: fix build due to type mismatches
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 111729
  Show dependency tree / graph
 
Reported: 2013-04-08 00:41 PDT by Alberto Garcia
Modified: 2013-04-09 00:41 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.33 KB, patch)
2013-04-08 00:45 PDT, Alberto Garcia 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alberto Garcia 2013-04-08 00:41:09 PDT 
Add explicit conversions between LayoutUnit and int, and between LayoutRect and IntRect.
Comment 1 Alberto Garcia 2013-04-08 00:45:31 PDT 
Created attachment 196835 [details]
Patch
Comment 2 Rob Buis 2013-04-08 04:34:24 PDT 
Comment on attachment 196835 [details]
Patch

What changed so that we need to do this?
Comment 3 WebKit Commit Bot 2013-04-08 18:32:36 PDT 
Comment on attachment 196835 [details]
Patch

Clearing flags on attachment: 196835

Committed r147973: <http://trac.webkit.org/changeset/147973>
Comment 4 WebKit Commit Bot 2013-04-08 18:32:38 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Alberto Garcia 2013-04-09 00:41:26 PDT 
(In reply to comment #2)
> (From update of attachment 196835 [details])
> What changed so that we need to do this?

This was upstreamed on year ago (r108718) and I'm not sure if it ever
compiled.

For example, you can't implicitly convert LayoutUnit in this case
because there are several candidates:

error: ambiguous overload for 'operator+=' in 'xOffset += renderBlock->WebCore::RenderBlock::<anonymous>.WebCore::RenderBox::x()'
note: candidates are:
note: operator+=(int&, int) <built-in>
note: operator+=(int&, unsigned int) <built-in>
note: operator+=(int&, float) <built-in>
note: operator+=(int&, double) <built-in>