Bug 114119 - Remove feature: CSS variables
: Remove feature: CSS variables
Status: RESOLVED FIXED
: WebKit
CSS
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2013-04-07 09:34 PST by
Modified: 2013-11-28 07:44 PST (History)


Attachments
Remove CSS variables (for EWS) (100.64 KB, patch)
2013-04-07 09:56 PST, Andreas Kling
no flags Review Patch | Details | Formatted Diff | Diff
Remove CSS variables (for EWS) (106.66 KB, patch)
2013-04-07 09:57 PST, Andreas Kling
webkit-ews: commit‑queue-
Review Patch | Details | Formatted Diff | Diff
I can't brain on Sundays (119.13 KB, patch)
2013-04-07 12:36 PST, Andreas Kling
webkit-ews: commit‑queue-
Review Patch | Details | Formatted Diff | Diff
rebased patch (206.84 KB, patch)
2013-11-28 07:24 PST, Antti Koivisto
akling: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2013-04-07 09:34:59 PST
The CSS variables feature was only shipped by Chromium and we should remove it, as it'll just start to bitrot.
------- Comment #1 From 2013-04-07 09:53:19 PST -------
<https://lists.webkit.org/pipermail/webkit-dev/2013-April/024476.html>
------- Comment #2 From 2013-04-07 09:56:17 PST -------
Created an attachment (id=196791) [details]
Remove CSS variables (for EWS)
------- Comment #3 From 2013-04-07 09:57:13 PST -------
Created an attachment (id=196792) [details]
Remove CSS variables (for EWS)
------- Comment #4 From 2013-04-07 10:05:22 PST -------
(From update of attachment 196792 [details])
Attachment 196792 [details] did not pass qt-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/17525742
------- Comment #5 From 2013-04-07 10:07:19 PST -------
(From update of attachment 196792 [details])
Attachment 196792 [details] did not pass qt-wk2-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/17540338
------- Comment #6 From 2013-04-07 10:25:26 PST -------
(From update of attachment 196792 [details])
Attachment 196792 [details] did not pass efl-ews (efl):
Output: http://webkit-commit-queue.appspot.com/results/17528774
------- Comment #7 From 2013-04-07 10:34:46 PST -------
(From update of attachment 196792 [details])
Attachment 196792 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/17446744
------- Comment #8 From 2013-04-07 10:44:21 PST -------
(From update of attachment 196792 [details])
Attachment 196792 [details] did not pass gtk-ews (gtk):
Output: http://webkit-commit-queue.appspot.com/results/17524750
------- Comment #9 From 2013-04-07 10:45:39 PST -------
(From update of attachment 196792 [details])
Attachment 196792 [details] did not pass mac-ews (mac):
Output: http://webkit-commit-queue.appspot.com/results/17486841
------- Comment #10 From 2013-04-07 12:36:36 PST -------
Created an attachment (id=196801) [details]
I can't brain on Sundays
------- Comment #11 From 2013-04-07 12:56:32 PST -------
(From update of attachment 196801 [details])
Attachment 196801 [details] did not pass qt-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/17423102
------- Comment #12 From 2013-04-07 13:02:00 PST -------
(From update of attachment 196801 [details])
Attachment 196801 [details] did not pass qt-wk2-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/17547013
------- Comment #13 From 2013-04-07 13:21:00 PST -------
(From update of attachment 196801 [details])
Attachment 196801 [details] did not pass efl-ews (efl):
Output: http://webkit-commit-queue.appspot.com/results/17504007
------- Comment #14 From 2013-04-07 13:25:08 PST -------
As a web developer, I have to say that this is an extremely disappointing decision. Apple should be turning this feature on in their browsers, not removing it.
------- Comment #15 From 2013-04-07 13:30:15 PST -------
(From update of attachment 196801 [details])
Attachment 196801 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/17522156
------- Comment #16 From 2013-04-07 14:00:48 PST -------
(From update of attachment 196801 [details])
Attachment 196801 [details] did not pass mac-ews (mac):
Output: http://webkit-commit-queue.appspot.com/results/17508024
------- Comment #17 From 2013-04-07 14:22:30 PST -------
(From update of attachment 196801 [details])
It would probably be a good idea to repeat the rationalle in the Changelog for future reference.
------- Comment #18 From 2013-04-07 14:30:47 PST -------
(In reply to comment #17)
> (From update of attachment 196801 [details] [details])
> It would probably be a good idea to repeat the rationalle in the Changelog for future reference.

Oh definitely. These are just my (lame) attempts at getting a green EWS before making the final patch.

(In reply to comment #14)
> As a web developer, I have to say that this is an extremely disappointing decision. Apple should be turning this feature on in their browsers, not removing it.

Please voice your concerns on the webkit-dev mailing list by responding to this thread: <https://lists.webkit.org/pipermail/webkit-dev/2013-April/024476.html>

Whether or not the feature is removed is still up for discussion. I'm just trying to be proactive here.
------- Comment #19 From 2013-04-07 15:13:58 PST -------
(From update of attachment 196801 [details])
Attachment 196801 [details] did not pass mac-ews (mac):
Output: http://webkit-commit-queue.appspot.com/results/17553004
------- Comment #20 From 2013-11-28 07:24:05 PST -------
Created an attachment (id=218002) [details]
rebased patch
------- Comment #21 From 2013-11-28 07:31:58 PST -------
(From update of attachment 218002 [details])
r=me.

Thank you for moving this forward. The code was nowhere near WebKit quality standards, and it's effectively unmaintained.
There should be something about that in the ChangeLog.
------- Comment #22 From 2013-11-28 07:44:55 PST -------
ttps://trac.webkit.org/r159842