The CSS variables feature was only shipped by Chromium and we should remove it, as it'll just start to bitrot.
<https://lists.webkit.org/pipermail/webkit-dev/2013-April/024476.html>
Created attachment 196791 [details] Remove CSS variables (for EWS)
Created attachment 196792 [details] Remove CSS variables (for EWS)
Comment on attachment 196792 [details] Remove CSS variables (for EWS) Attachment 196792 [details] did not pass qt-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/17525742
Comment on attachment 196792 [details] Remove CSS variables (for EWS) Attachment 196792 [details] did not pass qt-wk2-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/17540338
Comment on attachment 196792 [details] Remove CSS variables (for EWS) Attachment 196792 [details] did not pass efl-ews (efl): Output: http://webkit-commit-queue.appspot.com/results/17528774
Comment on attachment 196792 [details] Remove CSS variables (for EWS) Attachment 196792 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-commit-queue.appspot.com/results/17446744
Comment on attachment 196792 [details] Remove CSS variables (for EWS) Attachment 196792 [details] did not pass gtk-ews (gtk): Output: http://webkit-commit-queue.appspot.com/results/17524750
Comment on attachment 196792 [details] Remove CSS variables (for EWS) Attachment 196792 [details] did not pass mac-ews (mac): Output: http://webkit-commit-queue.appspot.com/results/17486841
Created attachment 196801 [details] I can't brain on Sundays
Comment on attachment 196801 [details] I can't brain on Sundays Attachment 196801 [details] did not pass qt-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/17423102
Comment on attachment 196801 [details] I can't brain on Sundays Attachment 196801 [details] did not pass qt-wk2-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/17547013
Comment on attachment 196801 [details] I can't brain on Sundays Attachment 196801 [details] did not pass efl-ews (efl): Output: http://webkit-commit-queue.appspot.com/results/17504007
As a web developer, I have to say that this is an extremely disappointing decision. Apple should be turning this feature on in their browsers, not removing it.
Comment on attachment 196801 [details] I can't brain on Sundays Attachment 196801 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-commit-queue.appspot.com/results/17522156
Comment on attachment 196801 [details] I can't brain on Sundays Attachment 196801 [details] did not pass mac-ews (mac): Output: http://webkit-commit-queue.appspot.com/results/17508024
Comment on attachment 196801 [details] I can't brain on Sundays It would probably be a good idea to repeat the rationalle in the Changelog for future reference.
(In reply to comment #17) > (From update of attachment 196801 [details]) > It would probably be a good idea to repeat the rationalle in the Changelog for future reference. Oh definitely. These are just my (lame) attempts at getting a green EWS before making the final patch. (In reply to comment #14) > As a web developer, I have to say that this is an extremely disappointing decision. Apple should be turning this feature on in their browsers, not removing it. Please voice your concerns on the webkit-dev mailing list by responding to this thread: <https://lists.webkit.org/pipermail/webkit-dev/2013-April/024476.html> Whether or not the feature is removed is still up for discussion. I'm just trying to be proactive here.
Comment on attachment 196801 [details] I can't brain on Sundays Attachment 196801 [details] did not pass mac-ews (mac): Output: http://webkit-commit-queue.appspot.com/results/17553004
Created attachment 218002 [details] rebased patch
Comment on attachment 218002 [details] rebased patch r=me. Thank you for moving this forward. The code was nowhere near WebKit quality standards, and it's effectively unmaintained. There should be something about that in the ChangeLog.
ttps://trac.webkit.org/r159842