Bug 114112 - Remove the rest of SVG_DOM_OBJC_BINDINGS
Summary: Remove the rest of SVG_DOM_OBJC_BINDINGS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords:
Depends on: 114076
Blocks:
  Show dependency tree / graph
 
Reported: 2013-04-07 03:38 PDT by David Kilzer (:ddkilzer)
Modified: 2013-04-07 13:55 PDT (History)
20 users (show)

See Also:

Attachments
Patch (32.92 KB, patch)
2013-04-07 04:29 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
Patch v2 (31.20 KB, patch)
2013-04-07 09:27 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2013-04-07 03:38:26 PDT 
The SVG DOM Objective-C bindings were mostly removed by Bug 114076, but there are a few pieces left to clean up.
Comment 1 David Kilzer (:ddkilzer) 2013-04-07 04:29:29 PDT 
Created attachment 196777 [details]
Patch
Comment 2 Carlos Garcia Campos 2013-04-07 04:41:32 PDT 
Comment on attachment 196777 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=196777&action=review

> Source/WebCore/ChangeLog:18
> +        * bindings/gobject/GNUmakefile.am:
> +        - Remove DOMHTMLFrameElementPrivate.h since the only method it
> +          contained was -[DOMHTMLFrameElement getSVGDocument], which was
> +          part of the SVG DOM Objective-C bindings.

I don't think this is right, WebKitDOMHTMLFrameElementPrivate.h contains the core/kit prototypes of WebKitDOMHTMLFrameElement, but it shoulnd't have anything related to SVG, since AFAIK we have never generated bindings for SVG.
Comment 3 kov's GTK+ EWS bot 2013-04-07 04:56:43 PDT 
Comment on attachment 196777 [details]
Patch

Attachment 196777 [details] did not pass gtk-ews (gtk):
Output: http://webkit-commit-queue.appspot.com/results/17438797
Comment 4 David Kilzer (:ddkilzer) 2013-04-07 09:24:07 PDT 
(In reply to comment #2)
> (From update of attachment 196777 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=196777&action=review
> 
> > Source/WebCore/ChangeLog:18
> > +        * bindings/gobject/GNUmakefile.am:
> > +        - Remove DOMHTMLFrameElementPrivate.h since the only method it
> > +          contained was -[DOMHTMLFrameElement getSVGDocument], which was
> > +          part of the SVG DOM Objective-C bindings.
> 
> I don't think this is right, WebKitDOMHTMLFrameElementPrivate.h contains the core/kit prototypes of WebKitDOMHTMLFrameElement, but it shoulnd't have anything related to SVG, since AFAIK we have never generated bindings for SVG.

Thanks!  I specifically CCed you on this bug to make sure I wasn't doing anything dumb.  I guess the GTK EWS caught the issue as well.
Comment 5 David Kilzer (:ddkilzer) 2013-04-07 09:27:24 PDT 
Created attachment 196789 [details]
Patch v2
Comment 6 Geoffrey Garen 2013-04-07 12:42:17 PDT 
Comment on attachment 196789 [details]
Patch v2

r=me
Comment 7 WebKit Commit Bot 2013-04-07 13:55:13 PDT 
Comment on attachment 196789 [details]
Patch v2

Clearing flags on attachment: 196789

Committed r147878: <http://trac.webkit.org/changeset/147878>
Comment 8 WebKit Commit Bot 2013-04-07 13:55:16 PDT 
All reviewed patches have been landed.  Closing bug.