Bug 114112 – Remove the rest of SVG_DOM_OBJC_BINDINGS

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit API

[David Kilzer (:ddkilzer)]

The SVG DOM Objective-C bindings were mostly removed by Bug 114076, but there are a few pieces left to clean up.

[David Kilzer (:ddkilzer)]

Created attachment 196777 [details]
Patch

[Carlos Garcia Campos]

Comment on attachment 196777 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=196777&action=review

> Source/WebCore/ChangeLog:18
> +        * bindings/gobject/GNUmakefile.am:
> +        - Remove DOMHTMLFrameElementPrivate.h since the only method it
> +          contained was -[DOMHTMLFrameElement getSVGDocument], which was
> +          part of the SVG DOM Objective-C bindings.

I don't think this is right, WebKitDOMHTMLFrameElementPrivate.h contains the core/kit prototypes of WebKitDOMHTMLFrameElement, but it shoulnd't have anything related to SVG, since AFAIK we have never generated bindings for SVG.

[kov's GTK+ EWS bot]

Comment on attachment 196777 [details]
Patch

Attachment 196777 [details] did not pass gtk-ews (gtk):
Output: http://webkit-commit-queue.appspot.com/results/17438797

[David Kilzer (:ddkilzer)]

(In reply to comment #2)
> (From update of attachment 196777 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=196777&action=review
> 
> > Source/WebCore/ChangeLog:18
> > +        * bindings/gobject/GNUmakefile.am:
> > +        - Remove DOMHTMLFrameElementPrivate.h since the only method it
> > +          contained was -[DOMHTMLFrameElement getSVGDocument], which was
> > +          part of the SVG DOM Objective-C bindings.
> 
> I don't think this is right, WebKitDOMHTMLFrameElementPrivate.h contains the core/kit prototypes of WebKitDOMHTMLFrameElement, but it shoulnd't have anything related to SVG, since AFAIK we have never generated bindings for SVG.

Thanks!  I specifically CCed you on this bug to make sure I wasn't doing anything dumb.  I guess the GTK EWS caught the issue as well.

[David Kilzer (:ddkilzer)]

Created attachment 196789 [details]
Patch v2

[Geoffrey Garen]

Comment on attachment 196789 [details]
Patch v2

r=me

[WebKit Commit Bot]

Comment on attachment 196789 [details]
Patch v2

Clearing flags on attachment: 196789

Committed r147878: <http://trac.webkit.org/changeset/147878>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.