Bug 114110 - Do not allocate static AtomicStrings when searching for alternate font names
Summary: Do not allocate static AtomicStrings when searching for alternate font names
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-06 21:44 PDT by Benjamin Poulain
Modified: 2013-04-07 18:00 PDT (History)
0 users

See Also:

Attachments
Patch (7.92 KB, patch)
2013-04-06 22:05 PDT, Benjamin Poulain 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2013-04-06 21:44:34 PDT 
Do not allocate static AtomicStrings when searching for alternate font names
Comment 1 Benjamin Poulain 2013-04-06 22:05:27 PDT 
Created attachment 196769 [details]
Patch
Comment 2 Geoffrey Garen 2013-04-07 12:38:33 PDT 
Comment on attachment 196769 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=196769&action=review

r=me

> Source/WebCore/ChangeLog:25
> +        To avoid comparing the input to every string, every time, the lenght of

Typo: length.

> Source/WebCore/platform/graphics/FontCache.cpp:156
> +    // Alias Arial and Helvetica

Typo: Needs a ".".
Comment 3 Benjamin Poulain 2013-04-07 18:00:23 PDT 
Committed r147889: <http://trac.webkit.org/changeset/147889>