Bug 114086 - [EFL] --minimal build fails with error: ‘UINT_MAX’ was not declared in this scope
Summary: [EFL] --minimal build fails with error: ‘UINT_MAX’ was not declared in this s...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: EasyFix
Depends on:
Blocks:
 
Reported: 2013-04-06 06:21 PDT by Ed Bartosh
Modified: 2013-04-06 14:20 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.11 KB, patch)
2013-04-06 06:30 PDT, Ed Bartosh
ggaren: review+
Details | Formatted Diff | Diff
Patch (1.15 KB, patch)
2013-04-06 10:59 PDT, Ed Bartosh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Bartosh 2013-04-06 06:21:23 PDT
build-webkit --efl --cmakeargs='-DSHARED_CORE=ON' --release fails with this error:
/home/ed/git/wk/WebKit/Tools/DumpRenderTree/AccessibilityUIElement.cpp: In function ‘const OpaqueJSValue* boundsForRangeCallback(JSContextRef, JSObjectRef, JSObjectRef, size_t, const OpaqueJSValue* const*, const OpaqueJSValue**)’:
/home/ed/git/wk/WebKit/Tools/DumpRenderTree/AccessibilityUIElement.cpp:144:25: error: ‘UINT_MAX’ was not declared in this scope
/home/ed/git/wk/WebKit/Tools/DumpRenderTree/AccessibilityUIElement.cpp: In function ‘const OpaqueJSValue* stringForRangeCallback(JSContextRef, JSObjectRef, JSObjectRef, size_t, const OpaqueJSValue* const*, const OpaqueJSValue**)’:
/home/ed/git/wk/WebKit/Tools/DumpRenderTree/AccessibilityUIElement.cpp:168:25: error: ‘UINT_MAX’ was not declared in this scope
/home/ed/git/wk/WebKit/Tools/DumpRenderTree/AccessibilityUIElement.cpp: In function ‘const OpaqueJSValue* attributedStringForRangeCallback(JSContextRef, JSObjectRef, JSObjectRef, size_t, const OpaqueJSValue* const*, const OpaqueJSValue**)’:
/home/ed/git/wk/WebKit/Tools/DumpRenderTree/AccessibilityUIElement.cpp:180:25: error: ‘UINT_MAX’ was not declared in this scope
/home/ed/git/wk/WebKit/Tools/DumpRenderTree/AccessibilityUIElement.cpp: In function ‘const OpaqueJSValue* attributedStringRangeIsMisspelledCallback(JSContextRef, JSObjectRef, JSObjectRef, size_t, const OpaqueJSValue* const*, const OpaqueJSValue**)’:
/home/ed/git/wk/WebKit/Tools/DumpRenderTree/AccessibilityUIElement.cpp:192:25: error: ‘UINT_MAX’ was not declared in this scope
/home/ed/git/wk/WebKit/Tools/DumpRenderTree/AccessibilityUIElement.cpp: In function ‘const OpaqueJSValue* setSelectedTextRangeCallback(JSContextRef, JSObjectRef, JSObjectRef, size_t, const OpaqueJSValue* const*, const OpaqueJSValue**)’:
/home/ed/git/wk/WebKit/Tools/DumpRenderTree/AccessibilityUIElement.cpp:507:25: error: ‘UINT_MAX’ was not declared in this scope
make[2]: *** [Tools/DumpRenderTree/efl/CMakeFiles/DumpRenderTree.dir/__/AccessibilityUIElement.cpp.o] Error 1
make[1]: *** [Tools/DumpRenderTree/efl/CMakeFiles/DumpRenderTree.dir/all] Error 2
Comment 1 Ed Bartosh 2013-04-06 06:30:11 PDT
Created attachment 196732 [details]
Patch
Comment 2 Geoffrey Garen 2013-04-06 10:24:35 PDT
Comment on attachment 196732 [details]
Patch

r=me
Comment 3 Geoffrey Garen 2013-04-06 10:25:06 PDT
Comment on attachment 196732 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=196732&action=review

> Tools/ChangeLog:3
> +        [EFL] build fails with error: âUINT_MAXâ was not declared in this scope

There seems to be a character encoding issue in your ChangeLog. Please fix before landing.
Comment 4 Ed Bartosh 2013-04-06 10:59:19 PDT
Created attachment 196745 [details]
Patch

Fixed. Please review.
Comment 5 WebKit Commit Bot 2013-04-06 14:20:00 PDT
Comment on attachment 196745 [details]
Patch

Clearing flags on attachment: 196745

Committed r147854: <http://trac.webkit.org/changeset/147854>
Comment 6 WebKit Commit Bot 2013-04-06 14:20:02 PDT
All reviewed patches have been landed.  Closing bug.