Bug 114083 - Remove remaining PLATFORM(CHROMIUM) guards in TestWebKitAPI, WebKitTestRunner
Summary: Remove remaining PLATFORM(CHROMIUM) guards in TestWebKitAPI, WebKitTestRunner
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-06 01:08 PDT by Zan Dobersek
Modified: 2013-04-06 14:18 PDT (History)
2 users (show)

See Also:

Attachments
Patch (3.32 KB, patch)
2013-04-06 01:09 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 (755.71 KB, application/zip)
2013-04-06 03:52 PDT, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2013-04-06 01:08:56 PDT 
Remove remaining PLATFORM(CHROMIUM) guards in TestWebKitAPI, WebKitTestRunner
Comment 1 Zan Dobersek 2013-04-06 01:09:51 PDT 
Created attachment 196721 [details]
Patch
Comment 2 Build Bot 2013-04-06 03:52:27 PDT 
Comment on attachment 196721 [details]
Patch

Attachment 196721 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/17488461

New failing tests:
platform/mac-wk2/plugins/npp-setwindow-called-on-scroll.html
Comment 3 Build Bot 2013-04-06 03:52:28 PDT 
Created attachment 196729 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.2
Comment 4 Zan Dobersek 2013-04-06 09:07:15 PDT 
(In reply to comment #2)
> (From update of attachment 196721 [details])
> Attachment 196721 [details] did not pass mac-wk2-ews (mac-wk2):
> Output: http://webkit-commit-queue.appspot.com/results/17488461
> 
> New failing tests:
> platform/mac-wk2/plugins/npp-setwindow-called-on-scroll.html

This is a flaky test, not caused by the patch.
http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&tests=platform%2Fmac-wk2%2Fplugins%2Fnpp-setwindow-called-on-scroll.html
Comment 5 Zan Dobersek 2013-04-06 14:18:00 PDT 
Comment on attachment 196721 [details]
Patch

Clearing flags on attachment: 196721

Committed r147853: <http://trac.webkit.org/changeset/147853>
Comment 6 Zan Dobersek 2013-04-06 14:18:04 PDT 
All reviewed patches have been landed.  Closing bug.