Bug 114069 – [EFL] --minimal build fails with error: ‘class WebKit::DrawingAreaProxy’ has no member named ‘setVisibleContentsRect’

• Status: RESOLVED
• Resolution: WONTFIX
• Component: WebKit EFL

[Ed Bartosh]

./Tools/Scripts/build-webkit --efl --cmakeargs="-DSHARED_CORE=ON" --minimal fails with this error:

/home/ed/git/wk/WebKit/Source/WebKit2/UIProcess/efl/WebView.cpp: In member function ‘void WebKit::WebView::updateViewportSize()’:
/home/ed/git/wk/WebKit/Source/WebKit2/UIProcess/efl/WebView.cpp:287:22: error: ‘class WebKit::DrawingAreaProxy’ has no member named ‘setVisibleContentsRect’
/home/ed/git/wk/WebKit/Source/WebKit2/UIProcess/efl/WebView.cpp: At global scope:
/home/ed/git/wk/WebKit/Source/WebKit2/UIProcess/efl/WebView.cpp:543:6: warning: unused parameter ‘attr’ [-Wunused-parameter]
/home/ed/git/wk/WebKit/Source/WebKit2/UIProcess/efl/WebView.cpp:568:6: warning: unused parameter ‘contentsSize’ [-Wunused-parameter]
/home/ed/git/wk/WebKit/Source/WebKit2/UIProcess/efl/WebView.cpp:568:6: warning: unused parameter ‘coveredRect’ [-Wunused-parameter]
make[2]: *** [Source/WebKit2/CMakeFiles/ewebkit2.dir/UIProcess/efl/WebView.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [Source/WebKit2/CMakeFiles/ewebkit2.dir/all] Error 2
make: *** [all] Error 2

[Ed Bartosh]

Created attachment 196693 [details]
Patch

[Ed Bartosh]

Created attachment 196811 [details]
Patch

Rebased. Please, review.

[Ed Bartosh]

Guys, please review. It's a trivial change.

[Ed Bartosh]

Created attachment 197933 [details]
Patch

[Ed Bartosh]

Created attachment 198968 [details]
Patch

[Laszlo Gombos]

Ed, is the resulting binary functional ? 

I am not sure if WebKit2 on and COORDINATED_GRAPHICS off is an actual configuration that is expected to work.

[Ed Bartosh]

I don't know if it works or not. Just trying to fix --minimal build. Do you have another suggestions how to fix this build failure?

[Ed Bartosh]

Created attachment 201382 [details]
Patch

[Ed Bartosh]

What about to explicitly enable coordinated graphics for WebKit2 efl (see attached patch) ?

[Gyuyoung Kim]

Comment on attachment 201382 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=201382&action=review

> Source/cmake/OptionsEfl.cmake:155
> +if (ENABLE_WEBKIT2)

When we use --minimal option, tiled backing store is disabled. So, coordinate graphics is also disabled. As far as I know, coordinate graphics is depend on tiled backing store. I don't agree to enable coordinated graphics without tiled backing store. I think you need to find other method to fix this build break.

[Gyuyoung Kim]

Comment on attachment 201382 [details]
Patch

r- based on my comment.

[Michael Catanzaro]

Closing this bug because the EFL port has been removed from trunk.

If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this.