RESOLVED FIXED 114068
tryCacheGetByID sets StructureStubInfo accessType to an incorrect value 
https://bugs.webkit.org/show_bug.cgi?id=114068
Summary tryCacheGetByID sets StructureStubInfo accessType to an incorrect value
Mark Hahnenberg
Reported 2013-04-05 15:21:24 PDT
In the case where we have a non-Value cacheable property, we set the StructureStubInfo accessType to get_by_id_self, but then we don't patch self and instead patch in a get_by_id_self_fail. This leads to incorrect profiling data so when the DFG compiles the function, it uses a GetByOffset rather than a GetById, which leads to loading a GetterSetter directly out of an object.
Attachments
Patch (2.94 KB, patch)
2013-04-05 15:56 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Patch (12.60 KB, patch)
2013-04-05 16:31 PDT, Mark Hahnenberg 		ggaren: review+
mhahnenberg: commit-queue+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2013-04-05 15:54:19 PDT
<rdar://problem/13386525>
Mark Hahnenberg
Comment 2 2013-04-05 15:56:43 PDT
Created attachment 196694 [details] Patch
Geoffrey Garen
Comment 3 2013-04-05 15:57:41 PDT
Comment on attachment 196694 [details] Patch Layout test!
Mark Hahnenberg
Comment 4 2013-04-05 15:57:59 PDT
(In reply to comment #3) > (From update of attachment 196694 [details]) > Layout test! Working on it :-(
Mark Hahnenberg
Comment 5 2013-04-05 16:31:24 PDT
Created attachment 196696 [details] Patch
Geoffrey Garen
Comment 6 2013-04-05 16:43:23 PDT
Comment on attachment 196696 [details] Patch r=me
Mark Hahnenberg
Comment 7 2013-04-05 16:49:44 PDT
Grr, forgot the commit queue was run by Google...now I can't un-cq+. Oh well!
Mark Hahnenberg
Comment 8 2013-04-05 16:50:48 PDT
Committed r147816: <http://trac.webkit.org/changeset/147816>
Note You need to log in before you can comment on or make changes to this bug.