Bug 114061 - [GTK] Change from PLATFORM(GTK) to USE(GLIB) in WTF/CurrentTime.cpp
Summary: [GTK] Change from PLATFORM(GTK) to USE(GLIB) in WTF/CurrentTime.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jesus Sanchez-Palencia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-05 13:44 PDT by Jesus Sanchez-Palencia
Modified: 2013-04-08 05:57 PDT (History)
9 users (show)

See Also:


Attachments
Patch (1.66 KB, patch)
2013-04-05 13:47 PDT, Jesus Sanchez-Palencia
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jesus Sanchez-Palencia 2013-04-05 13:44:37 PDT
[GTK] Change from PLATFORM(GTK) to USE(GLIB) in WTF/CurrentTime.cpp
Comment 1 Jesus Sanchez-Palencia 2013-04-05 13:47:20 PDT
Created attachment 196675 [details]
Patch
Comment 2 WebKit Commit Bot 2013-04-05 14:45:43 PDT
Comment on attachment 196675 [details]
Patch

Clearing flags on attachment: 196675

Committed r147799: <http://trac.webkit.org/changeset/147799>
Comment 3 WebKit Commit Bot 2013-04-05 14:45:45 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Csaba Osztrogonác 2013-04-08 05:40:27 PDT
(In reply to comment #2)
> (From update of attachment 196675 [details])
> Clearing flags on attachment: 196675
> 
> Committed r147799: <http://trac.webkit.org/changeset/147799>

It broke the Qt MIPS build. It seems Qt-MIPS port uses GLIB:
/data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/WTF/wtf/CurrentTime.cpp: In function 'double WTF::monotonicallyIncreasingTime()':
/data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/WTF/wtf/CurrentTime.cpp:298: error: 'g_get_monotonic_time' was not declared in this scope

I cc-ed MIPS maintainters.
Comment 5 Csaba Osztrogonác 2013-04-08 05:44:03 PDT
Not only MIPS, but Qt port uses GLIB if GStreamer is used.
Comment 6 Jesus Sanchez-Palencia 2013-04-08 05:54:11 PDT
(In reply to comment #5)
> Not only MIPS, but Qt port uses GLIB if GStreamer is used.

If Qt doesn't want to use the GLib implementation, being it for MIPS or not, then I can add a !PLATFORM(QT) there.

What do you think?
Comment 7 Csaba Osztrogonác 2013-04-08 05:57:16 PDT
(In reply to comment #6)
> (In reply to comment #5)
> > Not only MIPS, but Qt port uses GLIB if GStreamer is used.
> 
> If Qt doesn't want to use the GLib implementation, being it for MIPS or not, then I can add a !PLATFORM(QT) there.
> 
> What do you think?

I exactly thought this fix and then landed in http://trac.webkit.org/changeset/147910 :)