Bug 114057 - [GTK][AC] use a smart pointer for GList and ClutterCanvas
Summary: [GTK][AC] use a smart pointer for GList and ClutterCanvas
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Blocks: 105699
  Show dependency treegraph
Reported: 2013-04-05 13:00 PDT by ChangSeok Oh
Modified: 2013-04-11 07:40 PDT (History)
2 users (show)

See Also:

Patch (3.94 KB, patch)
2013-04-05 13:12 PDT, ChangSeok Oh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description ChangSeok Oh 2013-04-05 13:00:11 PDT
We can make simple code & prevent possible memory leak by using smart pointer.
Comment 1 ChangSeok Oh 2013-04-05 13:12:38 PDT
Created attachment 196672 [details]
Comment 2 Gustavo Noronha (kov) 2013-04-11 06:55:15 PDT
Comment on attachment 196672 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=196672&action=review

> Source/WebCore/platform/graphics/clutter/GraphicsLayerActor.cpp:286
> +    int width = std::max(static_cast<int>(ceilf(clutter_actor_get_width(actor))), 1);
> +    int height = std::max(static_cast<int>(ceilf(clutter_actor_get_height(actor))), 1);

fwiw, I'm not sure this size or 1 is required with ClutterCanvas, might be worth checking.
Comment 3 WebKit Commit Bot 2013-04-11 07:40:46 PDT
Comment on attachment 196672 [details]

Clearing flags on attachment: 196672

Committed r148202: <http://trac.webkit.org/changeset/148202>
Comment 4 WebKit Commit Bot 2013-04-11 07:40:48 PDT
All reviewed patches have been landed.  Closing bug.